Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1003813004: SkyShell DCHECKs on startup (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

SkyShell DCHECKs on startup We need to update how we initialize JNI to make sure we get an AtExitManager. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/859f8fc7246a3644bb20a6f9241b6acae3e8fca3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M sky/shell/library_loader.cc View 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-13 17:31:45 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-13 17:48:02 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-13 17:48:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
859f8fc7246a3644bb20a6f9241b6acae3e8fca3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698