Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py

Issue 1003773003: Disable SafeBrowsingOff test for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unneccesary blackslash Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py b/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
index c54af10f6e854059d30cd4ae2abfaedaa1c8a351..c9961e7718c20978bbf3207b235b2fe48b009528 100644
--- a/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
@@ -5,8 +5,13 @@
from integration_tests import chrome_proxy_measurements as measurements
from integration_tests import chrome_proxy_pagesets as pagesets
from telemetry import benchmark
+from telemetry.core.backends.chrome import android_browser_finder
+ANDROID_CHROME_BROWSERS = [
+ browser for browser in android_browser_finder.CHROME_PACKAGE_NAMES
+ if 'webview' not in browser]
+
class ChromeProxyLatency(benchmark.Benchmark):
tag = 'latency'
test = measurements.ChromeProxyLatency
@@ -149,7 +154,7 @@ class ChromeProxyBlockOnce(benchmark.Benchmark):
return 'chrome_proxy_benchmark.block_once.block_once'
-@benchmark.Enabled('android')
+@benchmark.Enabled(*ANDROID_CHROME_BROWSERS)
# Safebrowsing is enabled for Android and iOS.
class ChromeProxySafeBrowsingOn(benchmark.Benchmark):
tag = 'safebrowsing_on'
@@ -161,6 +166,7 @@ class ChromeProxySafeBrowsingOn(benchmark.Benchmark):
return 'chrome_proxy_benchmark.safebrowsing_on.safebrowsing'
+@benchmark.Disabled(*ANDROID_CHROME_BROWSERS)
# Safebrowsing is switched off for Android Webview and all desktop platforms.
class ChromeProxySafeBrowsingOff(benchmark.Benchmark):
tag = 'safebrowsing_off'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698