mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl - Issue 1003773002: CPP bindings: DCHECK when a Callback is destructed without being invoked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl

Issue 1003773002: CPP bindings: DCHECK when a Callback is destructed without being invoked (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Adds close() notification to Stub when Binding is closed or deleted. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/binding.h ('K') | « mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl ('k') | services/view_manager/view_manager_service_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl

index 03120024fda3dda88c0df3f02b8b85892323b5a4..cecbf07e8a357674781481a497f266d90f3ee101 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl

@@ -10,6 +10,7 @@

#include "mojo/public/cpp/bindings/array.h"

#include "mojo/public/cpp/bindings/callback.h"

+#include "mojo/public/cpp/bindings/error_handler.h"

#include "mojo/public/cpp/bindings/interface_impl.h"

#include "mojo/public/cpp/bindings/interface_ptr.h"

#include "mojo/public/cpp/bindings/interface_request.h"