mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl - Issue 1003773002: CPP bindings: DCHECK when a Callback is destructed without being invoked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl

Issue 1003773002: CPP bindings: DCHECK when a Callback is destructed without being invoked (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebased again Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl ('k') | services/view_manager/view_manager_service_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl

index 1abc3b99371cdd0b4a4f43efe3b90e7f9a692dee..05a249582679ee2a54de1e57122e4f297554d30a 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl

@@ -1,12 +1,13 @@

-class {{interface.name}}Stub : public mojo::MessageReceiverWithResponder {

+class {{interface.name}}Stub : public mojo::MessageReceiverWithResponderStatus {

public:

{{interface.name}}Stub();

+ ~{{interface.name}}Stub() override;

void set_sink({{interface.name}}* sink) { sink_ = sink; }

{{interface.name}}* sink() { return sink_; }

bool Accept(mojo::Message* message) override;

bool AcceptWithResponder(mojo::Message* message,

- mojo::MessageReceiver* responder) override;

+ mojo::MessageReceiverWithStatus* responder) override;

private:

{{interface.name}}* sink_;