Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1537)

Side by Side Diff: services/view_manager/view_manager_service_apptest.cc

Issue 1003773002: CPP bindings: DCHECK when a Callback is destructed without being invoked (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebased again Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "mojo/public/cpp/application/application_delegate.h" 8 #include "mojo/public/cpp/application/application_delegate.h"
9 #include "mojo/public/cpp/application/application_impl.h" 9 #include "mojo/public/cpp/application/application_impl.h"
10 #include "mojo/public/cpp/application/application_test_base.h" 10 #include "mojo/public/cpp/application/application_test_base.h"
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 void OnViewVisibilityChanged(uint32_t view, bool visible) override { 326 void OnViewVisibilityChanged(uint32_t view, bool visible) override {
327 tracker()->OnViewVisibilityChanged(view, visible); 327 tracker()->OnViewVisibilityChanged(view, visible);
328 } 328 }
329 void OnViewDrawnStateChanged(uint32_t view, bool drawn) override { 329 void OnViewDrawnStateChanged(uint32_t view, bool drawn) override {
330 tracker()->OnViewDrawnStateChanged(view, drawn); 330 tracker()->OnViewDrawnStateChanged(view, drawn);
331 } 331 }
332 void OnViewInputEvent(Id view_id, 332 void OnViewInputEvent(Id view_id,
333 EventPtr event, 333 EventPtr event,
334 const Callback<void()>& callback) override { 334 const Callback<void()>& callback) override {
335 tracker()->OnViewInputEvent(view_id, event.Pass()); 335 tracker()->OnViewInputEvent(view_id, event.Pass());
336 callback.Run();
336 } 337 }
337 void OnViewSharedPropertyChanged(uint32_t view, 338 void OnViewSharedPropertyChanged(uint32_t view,
338 const String& name, 339 const String& name,
339 Array<uint8_t> new_data) override { 340 Array<uint8_t> new_data) override {
340 tracker_.OnViewSharedPropertyChanged(view, name, new_data.Pass()); 341 tracker_.OnViewSharedPropertyChanged(view, name, new_data.Pass());
341 } 342 }
342 void OnPerformAction(uint32_t view, 343 void OnPerformAction(uint32_t view,
343 const String& name, 344 const String& name,
344 const Callback<void(bool)>& callback) override {} 345 const Callback<void(bool)>& callback) override {}
345 346
(...skipping 1143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1489 // TODO(sky): need to better track changes to initial connection. For example, 1490 // TODO(sky): need to better track changes to initial connection. For example,
1490 // that SetBounsdViews/AddView and the like don't result in messages to the 1491 // that SetBounsdViews/AddView and the like don't result in messages to the
1491 // originating connection. 1492 // originating connection.
1492 1493
1493 // TODO(sky): make sure coverage of what was 1494 // TODO(sky): make sure coverage of what was
1494 // ViewManagerTest.SecondEmbedRoot_InitService and 1495 // ViewManagerTest.SecondEmbedRoot_InitService and
1495 // ViewManagerTest.MultipleEmbedRootsBeforeWTHReady gets added to window manager 1496 // ViewManagerTest.MultipleEmbedRootsBeforeWTHReady gets added to window manager
1496 // tests. 1497 // tests.
1497 1498
1498 } // namespace view_manager 1499 } // namespace view_manager
OLDNEW
« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698