Issue 100373004: drive: Check OperationObserver::OnEntryUpdatedByOperation is called by MoveOperation in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100373004: drive: Check OperationObserver::OnEntryUpdatedByOperation is called by MoveOperation in tests (Closed)

Created:
7 years ago by hashimoto

Modified:
7 years ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Check OperationObserver::OnEntryUpdatedByOperation is called by MoveOperation in tests Both setting metadata_edit_state to DIRTY and calling OnEntryUpdateByOperation are necessary to trigger syncing. BUG=260538 TEST=unit_tests --gtest_filter="MoveOperationTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238366

Patch Set 1 #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/100373004/20001

7 years ago (2013-12-03 09:36:31 UTC) #3

Message was sent while issue was closed.

Change committed as 238366

Expand Messages | Collapse Messages