[bindings] Rename IDBBindingUtilities.cpp to V8BindingForModules.cpp

[bindings] Rename IDBBindingUtilities.cpp to V8BindingForModules.cpp

R=haraken@chromium.org, jsbell@chromium.org, jl@opera.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191815

[vivekg, 2015-03-12 13:12:45]

vivekg@chromium.org changed reviewers:
+ jl@opera.com, vivekg@chromium.org

[vivekg, 2015-03-12 13:12:45]

PTAL, thanks.

[jsbell, 2015-03-12 17:00:57]

The changes technically lgtm

I'm not totally sold on the name 'script_value_cast' or trying to make it look
like a C++ cast operator, but don't object if everyone else likes it.

https://codereview.chromium.org/1003713002/diff/1/Source/bindings/modules/v8/...
File Source/bindings/modules/v8/V8BindingForModules.cpp (right):

https://codereview.chromium.org/1003713002/diff/1/Source/bindings/modules/v8/...
Source/bindings/modules/v8/V8BindingForModules.cpp:445: IDBKeyRange*
NativeValueTraits<IDBKeyRange*>::nativeValue(const v8::Local<v8::Value>& value,
v8::Isolate* isolate, ExceptionState& exceptionState)
It seems like we could do something generic for ScriptWrappable types, maybe
generate this as part of V8XXXX?

But that may not be practical, and this is fine for this CL.

[haraken, 2015-03-12 23:34:51]

> I'm not totally sold on the name 'script_value_cast' or trying to make it look
> like a C++ cast operator, but don't object if everyone else likes it.
> 
>
https://codereview.chromium.org/1003713002/diff/1/Source/bindings/modules/v8/...
> File Source/bindings/modules/v8/V8BindingForModules.cpp (right):
> 
>
https://codereview.chromium.org/1003713002/diff/1/Source/bindings/modules/v8/...
> Source/bindings/modules/v8/V8BindingForModules.cpp:445: IDBKeyRange*
> NativeValueTraits<IDBKeyRange*>::nativeValue(const v8::Local<v8::Value>&
value,
> v8::Isolate* isolate, ExceptionState& exceptionState)
> It seems like we could do something generic for ScriptWrappable types, maybe
> generate this as part of V8XXXX?
> 
> But that may not be practical, and this is fine for this CL.

To mitigate the concerns, shall we split this CL into (three?) pieces?

- Rename IDBBindingUtilities.cpp to V8BindingForModules.cpp
- Use ScriptValue::from()
- Introduce script_value_cast<>

[vivekg, 2015-03-13 02:31:54]

Done. PTAL.

[vivekg, 2015-03-13 03:59:04]

On 2015/03/12 at 23:34:51, haraken wrote:
> > I'm not totally sold on the name 'script_value_cast' or trying to make it
look
> > like a C++ cast operator, but don't object if everyone else likes it.
> > 
> >
https://codereview.chromium.org/1003713002/diff/1/Source/bindings/modules/v8/...
> > File Source/bindings/modules/v8/V8BindingForModules.cpp (right):
> > 
> >
https://codereview.chromium.org/1003713002/diff/1/Source/bindings/modules/v8/...
> > Source/bindings/modules/v8/V8BindingForModules.cpp:445: IDBKeyRange*
> > NativeValueTraits<IDBKeyRange*>::nativeValue(const v8::Local<v8::Value>&
value,
> > v8::Isolate* isolate, ExceptionState& exceptionState)
> > It seems like we could do something generic for ScriptWrappable types, maybe
> > generate this as part of V8XXXX?
> > 
> > But that may not be practical, and this is fine for this CL.
> 
> To mitigate the concerns, shall we split this CL into (three?) pieces?
> 
> - Rename IDBBindingUtilities.cpp to V8BindingForModules.cpp
> - Use ScriptValue::from()
> - Introduce script_value_cast<>

Sure, I will submit subsequent patches once this renaming lands.

[haraken, 2015-03-13 04:14:18]

LGTM

[vivekg, 2015-03-13 04:16:04]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2015-03-13 04:16:05]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/1003713002/#ps20001
(title: "Renaming patch")

[commit-bot: I haz the power, 2015-03-13 04:16:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1003713002/20001

[commit-bot: I haz the power, 2015-03-13 05:22:33]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191815