Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1003683002: bindings: Moves WorkerGlobalScope's attributes to prototype chains. (Closed)

Created:
5 years, 9 months ago by Yuki
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Moves WorkerGlobalScope's attributes to prototype chains. BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191850

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 3 chunks +14 lines, -1 line 1 comment Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 chunks +14 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 3 chunks +14 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 chunks +14 lines, -0 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Yuki
Could you review this CL?
5 years, 9 months ago (2015-03-12 13:36:28 UTC) #2
haraken
LGTM https://codereview.chromium.org/1003683002/diff/20001/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt File LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt (right): https://codereview.chromium.org/1003683002/diff/20001/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt#newcode833 LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt:833: [Worker] getter location Are you sure that WorkerGlobalScope.location ...
5 years, 9 months ago (2015-03-12 23:38:47 UTC) #3
bashi
On 2015/03/12 23:38:47, haraken wrote: > LGTM > > https://codereview.chromium.org/1003683002/diff/20001/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt > File > LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt > ...
5 years, 9 months ago (2015-03-13 01:50:56 UTC) #4
Yuki
On 2015/03/13 01:50:56, bashi1 wrote: > On 2015/03/12 23:38:47, haraken wrote: > > LGTM > ...
5 years, 9 months ago (2015-03-13 08:25:27 UTC) #5
bashi
On 2015/03/13 08:25:27, Yuki wrote: > On 2015/03/13 01:50:56, bashi1 wrote: > > On 2015/03/12 ...
5 years, 9 months ago (2015-03-13 08:50:02 UTC) #6
haraken
On 2015/03/13 08:50:02, bashi1 wrote: > On 2015/03/13 08:25:27, Yuki wrote: > > On 2015/03/13 ...
5 years, 9 months ago (2015-03-13 08:58:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003683002/20001
5 years, 9 months ago (2015-03-13 13:32:40 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 16:11:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191850

Powered by Google App Engine
This is Rietveld 408576698