Add Cast() for Int32 and Uint32

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 2657 matching lines @@
 bool Value::IsBoolean() const {
   return Utils::OpenHandle(this)->IsBoolean();
 }
 
 
 bool Value::IsExternal() const {
   return Utils::OpenHandle(this)->IsExternal();
 }
 
 
-bool Value::IsInt32() const {
-  i::Handle<i::Object> obj = Utils::OpenHandle(this);
-  if (obj->IsSmi()) return true;
-  if (obj->IsNumber()) {
-    return i::IsInt32Double(obj->Number());
-  }
-  return false;
-}
+bool Value::IsInt32() const { return Utils::OpenHandle(this)->IsInt32(); }

[dcarney, 2015/03/12 10:45:58]

i don't think v8 cares internally about this distinction, there's no reason to
push this to objects.cc

[bashi, 2015/03/12 12:19:19]

Right. Reverted.

 
 
-bool Value::IsUint32() const {
-  i::Handle<i::Object> obj = Utils::OpenHandle(this);
-  if (obj->IsSmi()) return i::Smi::cast(*obj)->value() >= 0;
-  if (obj->IsNumber()) {
-    double value = obj->Number();
-    return !i::IsMinusZero(value) &&
-        value >= 0 &&
-        value <= i::kMaxUInt32 &&
-        value == i::FastUI2D(i::FastD2UI(value));
-  }
-  return false;
-}
+bool Value::IsUint32() const { return Utils::OpenHandle(this)->IsUint32(); }

[dcarney, 2015/03/12 10:45:58]

same

 
 
 static bool CheckConstructor(i::Isolate* isolate,
                              i::Handle<i::JSObject> obj,
                              const char* class_name) {
   i::Handle<i::Object> constr(obj->map()->GetConstructor(), isolate);
   if (!constr->IsJSFunction()) return false;
   i::Handle<i::JSFunction> func = i::Handle<i::JSFunction>::cast(constr);
   return func->shared()->native() && constr.is_identical_to(
       i::Object::GetProperty(isolate,
@@ skipping 256 matching lines @@
 
 
 void v8::Integer::CheckCast(v8::Value* that) {
   i::Handle<i::Object> obj = Utils::OpenHandle(that);
   Utils::ApiCheck(obj->IsNumber(),
                   "v8::Integer::Cast()",
                   "Could not convert to number");
 }
 
 
+void v8::Int32::CheckCast(v8::Value* that) {
+  i::Handle<i::Object> obj = Utils::OpenHandle(that);
+  Utils::ApiCheck(obj->IsInt32(), "v8::Int32::Cast()",

[dcarney, 2015/03/12 10:45:58]

just use that->IsInt32()

[bashi, 2015/03/12 12:19:19]

Done.

+                  "Could not convert to 32-bit signed integer");
+}
+
+
+void v8::Uint32::CheckCast(v8::Value* that) {
+  i::Handle<i::Object> obj = Utils::OpenHandle(that);

[dcarney, 2015/03/12 10:45:58]

same

+  Utils::ApiCheck(obj->IsUint32(), "v8::Uint32::Cast()",
+                  "Could not convert to 32-bit unsigned integer");
+}
+
+
 void v8::Array::CheckCast(Value* that) {
   i::Handle<i::Object> obj = Utils::OpenHandle(that);
   Utils::ApiCheck(obj->IsJSArray(),
                   "v8::Array::Cast()",
                   "Could not convert to array");
 }
 
 
 void v8::Promise::CheckCast(Value* that) {
   Utils::ApiCheck(that->IsPromise(),
@@ skipping 4990 matching lines @@
   Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 } }  // namespace v8::internal