Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1003653002: Remove *_version properties of ServiceWorkerRegistration and workerRegistrationDeleted event. (Closed)

Created:
5 years, 9 months ago by horo
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove *_version properties of ServiceWorkerRegistration and workerRegistrationDeleted event. After https://codereview.chromium.org/998173002/ we don't need them. This cl depends on https://codereview.chromium.org/998173002/. BUG=466871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M Source/devtools/front_end/sdk/ServiceWorkerManager.js View 2 chunks +2 lines, -11 lines 0 comments Download
M Source/devtools/protocol.json View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
horo
pfeldman@ Could you please review?
5 years, 9 months ago (2015-03-12 05:31:41 UTC) #2
horo
pfeldman@ ping?
5 years, 9 months ago (2015-03-13 16:16:26 UTC) #3
pfeldman
lgtm
5 years, 9 months ago (2015-03-14 05:04:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003653002/1
5 years, 9 months ago (2015-03-14 05:48:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003653002/1
5 years, 9 months ago (2015-03-19 08:43:26 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 10:28:22 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192151

Powered by Google App Engine
This is Rietveld 408576698