Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1003603004: PostMessageTest: retire use of zero-argument port.postMessage(). (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PostMessageTest: retire use of zero-argument port.postMessage(). In testPostUnsupportedWebMessageToApp, avoid invoking postMessage() without any arguments. At least one is required for MessagePort.postMessage(). R=sgurun@chromium.org BUG=339441 Committed: https://crrev.com/66e905bc98ee7f88a5e55a3c9c33cec47912983d Cr-Commit-Position: refs/heads/master@{#321855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look - hope I got the reviewers right.. :) We're trying to ...
5 years, 9 months ago (2015-03-23 19:49:23 UTC) #2
sgurun-gerrit only
On 2015/03/23 19:49:23, sof wrote: > Please take a look - hope I got the ...
5 years, 9 months ago (2015-03-23 20:22:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003603004/1
5 years, 9 months ago (2015-03-23 20:59:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 21:23:46 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:24:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66e905bc98ee7f88a5e55a3c9c33cec47912983d
Cr-Commit-Position: refs/heads/master@{#321855}

Powered by Google App Engine
This is Rietveld 408576698