Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1003593002: Instrumented libraries: the much-needed build script rewrite. (Closed)

Created:
5 years, 9 months ago by earthdok
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: the much-needed build script rewrite. Cleaner, no longer relying on pwd, and with 100% more OOP. BUG=none R=glider@chromium.org NOTRY=true Committed: https://crrev.com/a67c91a9d38e9054914c09b7bcd5c290e18645ec Cr-Commit-Position: refs/heads/master@{#320293}

Patch Set 1 #

Total comments: 24

Patch Set 2 : more refactoring #

Patch Set 3 : update comments #

Patch Set 4 : address comments to ps#1 #

Patch Set 5 : address remaining comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -367 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 1 2 3 4 1 chunk +350 lines, -358 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/instrumented_libraries/standard_instrumented_package_target.gypi View 1 2 3 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
earthdok
look on my works, ye mighty, and despair
5 years, 9 months ago (2015-03-11 21:40:57 UTC) #1
Alexander Potapenko
https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py File third_party/instrumented_libraries/download_build_install.py (right): https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py#newcode18 third_party/instrumented_libraries/download_build_install.py:18: # Must match the RPATH entry set in the ...
5 years, 9 months ago (2015-03-12 14:34:41 UTC) #2
Alexander Potapenko
https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py File third_party/instrumented_libraries/download_build_install.py (right): https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py#newcode94 third_party/instrumented_libraries/download_build_install.py:94: self.shell_call('apt-get source %s' % self._package, cwd=self._working_dir) Another long line. ...
5 years, 9 months ago (2015-03-12 14:54:30 UTC) #3
earthdok
https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py File third_party/instrumented_libraries/download_build_install.py (right): https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py#newcode18 third_party/instrumented_libraries/download_build_install.py:18: # Must match the RPATH entry set in the ...
5 years, 9 months ago (2015-03-12 14:55:17 UTC) #4
Alexander Potapenko
https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py File third_party/instrumented_libraries/download_build_install.py (right): https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py#newcode34 third_party/instrumented_libraries/download_build_install.py:34: GYP generates paths relative to the location of the ...
5 years, 9 months ago (2015-03-12 15:01:26 UTC) #5
Alexander Potapenko
LGTM in general.
5 years, 9 months ago (2015-03-12 15:02:38 UTC) #6
earthdok
https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py File third_party/instrumented_libraries/download_build_install.py (right): https://codereview.chromium.org/1003593002/diff/1/third_party/instrumented_libraries/download_build_install.py#newcode94 third_party/instrumented_libraries/download_build_install.py:94: self.shell_call('apt-get source %s' % self._package, cwd=self._working_dir) On 2015/03/12 14:54:30, ...
5 years, 9 months ago (2015-03-12 16:04:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003593002/80001
5 years, 9 months ago (2015-03-12 16:09:20 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
5 years, 9 months ago (2015-03-12 16:10:51 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 16:12:10 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a67c91a9d38e9054914c09b7bcd5c290e18645ec
Cr-Commit-Position: refs/heads/master@{#320293}

Powered by Google App Engine
This is Rietveld 408576698