Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1003553002: Update Button to be made of Material (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update Button to be made of Material To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7d249a32158add826b8f9d275689925a9ef6f31b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -92 lines) Patch
M sky/examples/stocks-fn/stockarrow.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/stocks-fn/stockrow.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/examples/stocks-fn/stocksapp.dart View 3 chunks +7 lines, -6 lines 0 comments Download
A + sky/examples/widgets-fn/main.sky View 1 chunk +7 lines, -2 lines 0 comments Download
A + sky/examples/widgets-fn/widgets_app.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/button.dart View 1 chunk +13 lines, -21 lines 0 comments Download
M sky/framework/components/checkbox.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/drawer.dart View 4 chunks +11 lines, -8 lines 0 comments Download
M sky/framework/components/drawer_header.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/fixed_height_scrollable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/floating_action_button.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M sky/framework/components/icon.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/components/ink_splash.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/input.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/components/material.dart View 4 chunks +31 lines, -7 lines 0 comments Download
M sky/framework/components/menu_divider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/menu_item.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/radio.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/toolbar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/editing/editable_text.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/fn.dart View 7 chunks +16 lines, -11 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-11 20:54:20 UTC) #1
rafaelw
lgtm. nice. https://codereview.chromium.org/1003553002/diff/1/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/1003553002/diff/1/sky/framework/fn.dart#newcode147 sky/framework/fn.dart:147: _class = ''; bit: _class = styles ...
5 years, 9 months ago (2015-03-11 21:17:15 UTC) #2
abarth-chromium
https://codereview.chromium.org/1003553002/diff/1/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/1003553002/diff/1/sky/framework/fn.dart#newcode147 sky/framework/fn.dart:147: _class = ''; On 2015/03/11 at 21:17:15, rafaelw wrote: ...
5 years, 9 months ago (2015-03-11 21:20:05 UTC) #3
abarth-chromium
5 years, 9 months ago (2015-03-11 21:20:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d249a32158add826b8f9d275689925a9ef6f31b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698