Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1003523004: Remove GestureInterpreterLibevdevCros::SetAllowedKeys() because it is a no-op (Closed)

Created:
5 years, 9 months ago by pkotwicz
Modified:
5 years, 9 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GestureInterpreterLibevdevCros::SetAllowedKeys() because it is a no-op EventConverterEvdev::SetAllowedKeys() and EvdevConverterEvdev::AllowAllKeys() are only called for internal keyboards. GestureInterpreterLibevdevCros is not used for internal keyboards. The current implementation of GestureInterpreterLibevdevCros::SetAllowedKeys() and GestureInterpreterLibevdevCros::AllowAllKeys() is buggy, so just remove it BUG=None TEST=None Committed: https://crrev.com/799b8c8ba33988575ab828780c772f7416d807dc Cr-Commit-Position: refs/heads/master@{#320155}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -48 lines) Patch
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 2 chunks +3 lines, -11 lines 1 comment Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pkotwicz
spang@ PTAL
5 years, 9 months ago (2015-03-11 21:10:48 UTC) #2
spang
https://codereview.chromium.org/1003523004/diff/1/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc File ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc (right): https://codereview.chromium.org/1003523004/diff/1/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc#newcode41 ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc:41: CHECK(!has_keyboard_ || type != INPUT_DEVICE_INTERNAL); DCHECK per the style ...
5 years, 9 months ago (2015-03-11 21:12:26 UTC) #3
spang
lgtm
5 years, 9 months ago (2015-03-11 21:12:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003523004/1
5 years, 9 months ago (2015-03-11 21:26:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 21:53:24 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 21:54:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/799b8c8ba33988575ab828780c772f7416d807dc
Cr-Commit-Position: refs/heads/master@{#320155}

Powered by Google App Engine
This is Rietveld 408576698