Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1003483004: ChannelMojo: Turn DLOG to LOG for ERROR and WARNING (Closed)

Created:
5 years, 9 months ago by Hajime Morrita
Modified:
5 years, 9 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChannelMojo: Turn DLOG to LOG for ERROR and WARNING It'd be useful to diagnose IPC related issues, especially Chrome OS builds where Release build is the norm. This shouldn't be noisy as these won't happen in normal use. R=viettrungluu@chromium.org TEST=466814 BUG= Committed: https://crrev.com/a3889aa737db9a6e94b24c5f5f0dc33154bfa2c6 Cr-Commit-Position: refs/heads/master@{#320810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_message_pipe_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_handle_attachment.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_message_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Hajime Morrita
5 years, 9 months ago (2015-03-13 23:42:30 UTC) #1
viettrungluu
lgtm
5 years, 9 months ago (2015-03-16 20:29:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003483004/1
5 years, 9 months ago (2015-03-16 20:39:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 22:41:00 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:42:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3889aa737db9a6e94b24c5f5f0dc33154bfa2c6
Cr-Commit-Position: refs/heads/master@{#320810}

Powered by Google App Engine
This is Rietveld 408576698