Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1977)

Unified Diff: remoting/webapp/js_proto/qunit_proto.js

Issue 1003433002: Updated remoting.xhr API to use promises. Removed access to the native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@spy-promise
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/webapp/crd/js/xhr.js ('K') | « remoting/webapp/crd/js/xhr_unittest.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/js_proto/qunit_proto.js
diff --git a/remoting/webapp/js_proto/qunit_proto.js b/remoting/webapp/js_proto/qunit_proto.js
index 8eb96452f3a29176ff3393156f14a0fbad227fb6..a3746d455bc6ec8eb6d6ba9531986994eee833c7 100644
--- a/remoting/webapp/js_proto/qunit_proto.js
+++ b/remoting/webapp/js_proto/qunit_proto.js
@@ -72,7 +72,7 @@ QUnit.start = function() {};
/**
* @param {string} desc
- * @param {Function} f
+ * @param {function(!QUnit.Assert)} f
*/
QUnit.test = function(desc, f) {};
@@ -87,8 +87,20 @@ QUnit.Assert = function() {};
/**
* @return {function():void}
*/
-QUnit.Assert.prototype.async = function() {};
+QUnit.Assert.prototype.async = function() {};
+
+// TODO(jrw): Make these the primary definitions.
+QUnit.Assert.prototype.deepEqual = QUnit.deepEqual;
+QUnit.Assert.prototype.equal = QUnit.equal;
+QUnit.Assert.prototype.notEqual = QUnit.notEqual;
+QUnit.Assert.prototype.ok = QUnit.ok;
+
+/**
+ * @const {!QUnit.Assert}
+ */
+QUnit.assert;
+// TODO(jrw): Mark these as deprecated.
kelvinp 2015/03/17 01:32:46 I am working on a change that will move QUnit to u
John Williams 2015/03/17 17:39:38 Acknowledged.
var deepEqual = QUnit.deepEqual;
var equal = QUnit.equal;
var expect = QUnit.expect;
« remoting/webapp/crd/js/xhr.js ('K') | « remoting/webapp/crd/js/xhr_unittest.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698