remoting/webapp/crd/js/session_connector_impl.js - Issue 1003433002: Updated remoting.xhr API to use promises. Removed access to the native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/session_connector_impl.js

Issue 1003433002: Updated remoting.xhr API to use promises. Removed access to the native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@spy-promise

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/webapp/crd/js/it2me_connect_flow.js ('K') | « remoting/webapp/crd/js/oauth2_api_impl.js ('k') | remoting/webapp/crd/js/third_party_token_fetcher.js » ('j') | remoting/webapp/crd/js/xhr.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/crd/js/session_connector_impl.js

diff --git a/remoting/webapp/crd/js/session_connector_impl.js b/remoting/webapp/crd/js/session_connector_impl.js

index b84feee9a8dddd85227d24242f1b31120a195569..fad6ae97ad94dfb4a1c6b06b3cac1ee8eb9228ce 100644

--- a/remoting/webapp/crd/js/session_connector_impl.js

+++ b/remoting/webapp/crd/js/session_connector_impl.js

@@ -95,6 +95,9 @@ remoting.SessionConnectorImpl = function(clientContainer, onConnected, onError,

remoting.SessionConnectorImpl.prototype.resetConnection_ = function() {

this.removePlugin_();

+ // It's OK to initialize these member variables here because the

+ // constructor calls this method.

/** @private {remoting.Host} */

this.host_ = null;

@@ -110,9 +113,6 @@ remoting.SessionConnectorImpl.prototype.resetConnection_ = function() {

/** @private {remoting.DesktopConnectedView} */

this.connectedView_ = null;

- /** @private {XMLHttpRequest} */

- this.pendingXhr_ = null;

/** @private {remoting.CredentialsProvider} */

this.credentialsProvider_ = null;