Updated remoting.xhr API to use promises. Removed access to the native

remoting/webapp/app_remoting/js/app_remoting.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * This class implements the functionality that is specific to application
  * remoting ("AppRemoting" or AR).
  */
 
@@ skipping 86 matching lines @@
  *
  * @param {remoting.SessionConnector} connector
  * @param {string} token An OAuth access token. The delegate should not cache
  *     this token, but can assume that it will remain valid during application
  *     start-up.
  */
 remoting.AppRemoting.prototype.start = function(connector, token) {
   /** @type {remoting.AppRemoting} */
   var that = this;
 
-  /** @param {XMLHttpRequest} xhr */
-  var parseAppHostResponse = function(xhr) {
-    if (xhr.status == 200) {
+  /** @param {remoting.Xhr.Response} xhrResponse */
+  var parseAppHostResponse = function(xhrResponse) {
+    if (xhrResponse.status == 200) {
       var response = /** @type {remoting.AppRemoting.AppHostResponse} */
-          (base.jsonParseSafe(xhr.responseText));
+          (base.jsonParseSafe(xhrResponse.textContent));
       if (response &&
           response.status &&
           response.status == 'done' &&
           response.hostJid &&
           response.authorizationCode &&
           response.sharedSecret &&
           response.host &&
           response.host.hostId) {
         var hostJid = response.hostJid;
         that.contextMenu_.setHostId(response.host.hostId);
@@ skipping 27 matching lines @@
         connector.connectMe2App(host, fetchThirdPartyToken);
       } else if (response && response.status == 'pending') {
         that.handleError(new remoting.Error(
             remoting.Error.Tag.SERVICE_UNAVAILABLE));
       }
     } else {
       console.error('Invalid "runApplication" response from server.');
       // TODO(garykac) Start using remoting.Error.fromHttpStatus once it has
       // been updated to properly report 'unknown' errors (rather than
       // reporting them as AUTHENTICATION_FAILED).
-      if (xhr.status == 0) {
+      if (xhrResponse.status == 0) {
         that.handleError(new remoting.Error(
             remoting.Error.Tag.NETWORK_FAILURE));
-      } else if (xhr.status == 401) {
+      } else if (xhrResponse.status == 401) {
         that.handleError(new remoting.Error(
             remoting.Error.Tag.AUTHENTICATION_FAILED));
-      } else if (xhr.status == 403) {
+      } else if (xhrResponse.status == 403) {
         that.handleError(new remoting.Error(
             remoting.Error.Tag.APP_NOT_AUTHORIZED));
-      } else if (xhr.status == 502 || xhr.status == 503) {
+      } else if (xhrResponse.status == 502 || xhrResponse.status == 503) {
         that.handleError(new remoting.Error(
             remoting.Error.Tag.SERVICE_UNAVAILABLE));
       } else {
         that.handleError(remoting.Error.unexpected());
       }
     }
   };
 
-  remoting.xhr.start({
+  new remoting.Xhr({
     method: 'POST',
     url: that.runApplicationUrl(),
-    onDone: parseAppHostResponse,
     oauthToken: token
-  });
+  }).start().then(parseAppHostResponse);
 };
 
 /**
  * Report an authentication error to the user. This is called in lieu of start()
  * if the user cannot be authenticated or if they decline the app permissions.
  *
  * @param {!remoting.Error} error The failure reason.
  */
 remoting.AppRemoting.prototype.signInFailed = function(error) {
   this.handleError(error);
 };
 
 /**
  * @return {string} Application product name to be used in UI.
  */
 remoting.AppRemoting.prototype.getApplicationName = function() {
   var manifest = chrome.runtime.getManifest();
-  return manifest.name;
+  // XXX return manifest.name;

[kelvinp, 2015/03/17 01:32:46]

what does //XXX stands for?

[John Williams, 2015/03/17 17:39:38]

"Don't commit this." Oops. I was testing to see if I could get JSCompile to
issue an error. Apparently the answer is no.

[kelvinp, 2015/03/17 22:06:20]

Acknowledged.

 };
 
 /** @return {string} */
 remoting.AppRemoting.prototype.runApplicationUrl = function() {
   return remoting.settings.APP_REMOTING_API_BASE_URL + '/applications/' +
       remoting.settings.getAppRemotingApplicationId() + '/run';
 };
 
 /**
  * @return {string} The default remap keys for the current platform.
@@ skipping 123 matching lines @@
  * Called when an error needs to be displayed to the user.
  *
  * @param {!remoting.Error} error The error to be localized and displayed.
  * @return {void} Nothing.
  */
 remoting.AppRemoting.prototype.handleError = function(error) {
   console.error('Connection failed: ' + error.toString());
   remoting.LoadingWindow.close();
   remoting.MessageWindow.showErrorMessage(
       chrome.i18n.getMessage(/*i18n-content*/'CONNECTION_FAILED'),
-      chrome.i18n.getMessage(/** @type {string} */ (error.tag)));
+      chrome.i18n.getMessage(error.getTag()));
 };
 
 /**
  * Close the loading window before exiting.
  */
 remoting.AppRemoting.prototype.handleExit = function() {
   remoting.LoadingWindow.close();
 };