Updated remoting.xhr API to use promises. Removed access to the native

remoting/webapp/crd/js/it2me_connect_flow.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 
 'use strict';
@@ skipping 70 matching lines @@
   this.hostId_ = normalizedAccessCode.substring(0, SUPPORT_ID_LENGTH);
   this.passCode_ = normalizedAccessCode;
 
   return Promise.resolve();
 };
 
 /**
  * Continues an IT2Me connection once an access token has been obtained.
  *
  * @param {string} token An OAuth2 access token.
- * @return {Promise<XMLHttpRequest>}
+ * @return {Promise<remoting.Xhr.Response>}
  * @private
  */
 remoting.It2MeConnectFlow.prototype.getHostInfo_ = function(token) {
   var that = this;
-  return new Promise(function(resolve) {
-    remoting.xhr.start({
-      method: 'GET',
-      url: remoting.settings.DIRECTORY_API_BASE_URL + '/support-hosts/' +
-           encodeURIComponent(that.hostId_),
-      onDone: resolve,
-      oauthToken: token
-    });
-  });
+  new remoting.Xhr({

[Jamie, 2015/03/16 18:06:34]

Don't you need to return this?

[John Williams, 2015/03/16 23:15:00]

Sure, if I was actually calling this method :-)  Pardon me while I write some
unit tests.

[John Williams, 2015/03/16 23:16:22]

Hey, wait, I removed this when I realized this wasn't new code I was writing,
and it just looks mean and sarcastic.

My actually response is that I fixed it, and I'm trying to track down why
jscompiler didn't report it earlier.

+    method: 'GET',
+    url: remoting.settings.DIRECTORY_API_BASE_URL + '/support-hosts/' +
+        encodeURIComponent(that.hostId_),
+    oauthToken: token
+  }).start();
 };
 
 /**
  * Continues an IT2Me connection once the host JID has been looked up.
  *
  * @param {XMLHttpRequest} xhr The server response to the support-hosts query.
  * @return {!Promise<!remoting.Host>} Rejects on error.
  * @private
  */
 remoting.It2MeConnectFlow.prototype.onHostInfo_ = function(xhr) {
@@ skipping 26 matching lines @@
   switch (error) {
     case 0: return new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE);
     case 404: return new remoting.Error(remoting.Error.Tag.INVALID_ACCESS_CODE);
     case 502: // No break
     case 503: return new remoting.Error(remoting.Error.Tag.SERVICE_UNAVAILABLE);
     default: return remoting.Error.unexpected();
   }
 }
 
 })();