Updated remoting.xhr API to use promises. Removed access to the native

remoting/webapp/app_remoting/js/feedback_consent.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @type {string} The host id corresponding to the user's VM. The @pending
  *     place-holder instructs the Orchestrator to abandon any pending host,
  *     and is used if no host id is provided by the main window.
@@ skipping 109 matching lines @@
   } else {
     if (abandonHost == 'yes') {
       var body = {
         'abandonHost': 'true',
         'crashServiceReportId': crashServiceReportId
       };
       var uri = remoting.settings.APP_REMOTING_API_BASE_URL +
           '/applications/' + remoting.settings.getAppRemotingApplicationId() +
           '/hosts/'  + hostId +
           '/reportIssue';
-      /** @param {XMLHttpRequest} xhr */
-      var onDone = function(xhr) {
-        if (xhr.status >= 200 && xhr.status < 300) {
+      /** @param {!remoting.Xhr.Response} response */

[Jamie, 2015/03/18 22:16:16]

Nit: Use the shorter, in-line "/** <type> */" syntax.

[John Williams, 2015/03/19 20:19:42]

Done.

+      var onDone = function(response) {
+        if (response.status >= 200 && response.status < 300) {
           getUserInfo();
         } else {
           showError();
         }
       };
-      remoting.xhr.start({
+      new remoting.Xhr({
         method: 'POST',
         url: uri,
-        onDone: onDone,
         jsonContent: body,
         oauthToken: token
-      });
+      }).start().then(onDone);
     } else {
       getUserInfo();
     }
   }
 }
 
 function onOk() {
   setWaiting(true);
   var abandon = /** @type {HTMLInputElement} */
       (document.getElementById('abandon-host'));
@@ skipping 69 matching lines @@
   var method = /** @type {string} */ (event.data['method']);
   if (method == 'init') {
     if (event.data['hostId']) {
       hostId = /** @type {string} */ (event.data['hostId']);
     }
     connectionStats = /** @type {string} */ (event.data['connectionStats']);
   }
 };
 
 window.addEventListener('load', onLoad, false);