Updated remoting.xhr API to use promises. Removed access to the native

remoting/webapp/crd/js/xmpp_connection.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 21 matching lines @@
   this.startTlsPending_ = false;
   /** @private {Array<ArrayBuffer>} */
   this.sendQueue_ = [];
   /** @private {remoting.XmppLoginHandler} */
   this.loginHandler_ = null;
   /** @private {remoting.XmppStreamParser} */
   this.streamParser_ = null;
   /** @private */
   this.jid_ = '';
   /** @private */
-  this.error_ = remoting.Error.NONE;
+  this.error_ = remoting.Error.none();
 };
 
 /**
  * @param {function(remoting.SignalStrategy.State):void} onStateChangedCallback
  */
 remoting.XmppConnection.prototype.setStateChangedCallback = function(
     onStateChangedCallback) {
   this.onStateChangedCallback_ = onStateChangedCallback;
 };
 
@@ skipping 14 matching lines @@
 /**
  * @param {string} server
  * @param {string} username
  * @param {string} authToken
  */
 remoting.XmppConnection.prototype.connect =
     function(server, username, authToken) {
   base.debug.assert(this.state_ == remoting.SignalStrategy.State.NOT_CONNECTED);
   base.debug.assert(this.onStateChangedCallback_ != null);
 
-  this.error_ = remoting.Error.NONE;
+  this.error_ = remoting.Error.none();
   var hostnameAndPort = server.split(':', 2);
   this.server_ = hostnameAndPort[0];
   this.port_ =
       (hostnameAndPort.length == 2) ? parseInt(hostnameAndPort[1], 10) : 5222;
 
   // The server name is passed as to attribute in the <stream>. When connecting
   // to talk.google.com it affects the certificate the server will use for TLS:
   // talk.google.com uses gmail certificate when specified server is gmail.com
   // or googlemail.com and google.com cert otherwise. In the same time it
   // doesn't accept talk.google.com as target server. Here we use google.com
@@ skipping 16 matching lines @@
       this.onHandshakeDone_.bind(this), this.onError_.bind(this));
   this.setState_(remoting.SignalStrategy.State.CONNECTING);
 
   if (!this.socket_) {
     this.socket_ = new remoting.TcpSocket();
   }
   var that = this;
   this.socket_.connect(this.server_, this.port_)
       .then(this.onSocketConnected_.bind(this))
       .catch(function(error) {
-        that.onError_(remoting.Error.NETWORK_FAILURE,
+        that.onError_(new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE),
                       'Failed to connect to ' + that.server_ + ': ' + error);
       });
 };
 
 /** @param {string} message */
 remoting.XmppConnection.prototype.sendMessage = function(message) {
   base.debug.assert(this.state_ == remoting.SignalStrategy.State.CONNECTED);
   this.sendString_(message);
 };
 
@@ skipping 60 matching lines @@
   } else if (this.state_ == remoting.SignalStrategy.State.CONNECTED) {
     this.streamParser_.appendData(data);
   }
 };
 
 /**
  * @param {number} errorCode
  * @private
  */
 remoting.XmppConnection.prototype.onReceiveError_ = function(errorCode) {
-  this.onError_(remoting.Error.NETWORK_FAILURE,
+  this.onError_(new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE),
                 'Failed to receive from XMPP socket: ' + errorCode);
 };
 
 /**
  * @param {string} text
  * @private
  */
 remoting.XmppConnection.prototype.sendString_ = function(text) {
   this.sendBuffer_(base.encodeUtf8(text));
 };
@@ skipping 18 matching lines @@
   var that = this;
 
   this.sendPending_ = true;
   this.socket_.send(this.sendQueue_[0])
       .then(function(/** number */ bytesSent) {
         that.sendPending_ = false;
         that.onSent_(bytesSent);
       })
       .catch(function(/** number */ error) {
         that.sendPending_ = false;
-        that.onError_(remoting.Error.NETWORK_FAILURE,
+        that.onError_(new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE),
                       'TCP write failed with error ' + error);
       });
 };
 
 /**
  * @param {number} bytesSent
  * @private
  */
 remoting.XmppConnection.prototype.onSent_ = function(bytesSent) {
   // Ignore send() result if the socket was closed.
@@ skipping 27 matching lines @@
   this.socket_.startTls()
       .then(function() {
         that.startTlsPending_ = false;
         that.socket_.startReceiving(that.onReceive_.bind(that),
                                     that.onReceiveError_.bind(that));
 
         that.loginHandler_.onTlsStarted();
       })
       .catch(function(/** number */ error) {
         that.startTlsPending_ = false;
-        that.onError_(remoting.Error.NETWORK_FAILURE,
+        that.onError_(new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE),
                       'Failed to start TLS: ' + error);
       });
 }
 
 /**
  * @param {string} jid
  * @param {remoting.XmppStreamParser} streamParser
  * @private
  */
 remoting.XmppConnection.prototype.onHandshakeDone_ =
@@ skipping 13 matching lines @@
   if (this.onIncomingStanzaCallback_) {
     this.onIncomingStanzaCallback_(stanza);
   }
 };
 
 /**
  * @param {string} text
  * @private
  */
 remoting.XmppConnection.prototype.onParserError_ = function(text) {
-  this.onError_(remoting.Error.UNEXPECTED, text);
-}
+  this.onError_(remoting.Error.unexpected(), text);
+};
 
 /**
  * @param {!remoting.Error} error
  * @param {string} text
  * @private
  */
 remoting.XmppConnection.prototype.onError_ = function(error, text) {
   console.error(text);
   this.error_ = error;
   base.dispose(this.socket_);
   this.socket_ = null;
   this.setState_(remoting.SignalStrategy.State.FAILED);
 };
 
 /**
  * @param {remoting.SignalStrategy.State} newState
  * @private
  */
 remoting.XmppConnection.prototype.setState_ = function(newState) {
   if (this.state_ != newState) {
     this.state_ = newState;
     this.onStateChangedCallback_(this.state_);
   }
 };