Updated remoting.xhr API to use promises. Removed access to the native

remoting/webapp/crd/js/session_connector_impl.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Connect set-up state machine for Me2Me and IT2Me
  */
 
 'use strict';
@@ skipping 77 matching lines @@
 };
 
 /**
  * Reset the per-connection state so that the object can be re-used for a
  * second connection. Note the none of the shared WCS state is reset.
  * @private
  */
 remoting.SessionConnectorImpl.prototype.resetConnection_ = function() {
   this.removePlugin_();
 
+  // It's OK to initialize these member variables here because the
+  // constructor calls this method.
+
   /** @private {remoting.Host} */
   this.host_ = null;
 
   /** @private {boolean} */
   this.logHostOfflineErrors_ = false;
 
   /** @private {remoting.ClientPlugin} */
   this.plugin_ = null;
 
   /** @private {remoting.ClientSession} */
   this.clientSession_ = null;
 
   /** @private {remoting.DesktopConnectedView} */
   this.connectedView_ = null;
 
-  /** @private {XMLHttpRequest} */
-  this.pendingXhr_ = null;
-
   /** @private {remoting.CredentialsProvider} */
   this.credentialsProvider_ = null;
 
   /** @private {Object<string,remoting.ProtocolExtension>} */
   this.protocolExtensions_ = {};
 };
 
 /**
  * Initiate a Me2Me connection.
  *
@@ skipping 211 matching lines @@
 };
 
 /**
  * @param {boolean} initialized
  * @private
  */
 remoting.SessionConnectorImpl.prototype.onPluginInitialized_ = function(
     initialized) {
   if (!initialized) {
     console.error('ERROR: remoting plugin not loaded');
-    this.pluginError_(remoting.Error.MISSING_PLUGIN);
+    this.pluginError_(new remoting.Error(remoting.Error.Tag.MISSING_PLUGIN));
     return;
   }
 
   if (!this.plugin_.isSupportedVersion()) {
     console.error('ERROR: bad plugin version');
-    this.pluginError_(remoting.Error.BAD_PLUGIN_VERSION);
+    this.pluginError_(new remoting.Error(
+        remoting.Error.Tag.BAD_PLUGIN_VERSION));
     return;
   }
 
   this.clientSession_ = new remoting.ClientSession(
       this.plugin_, this.host_, this.signalStrategy_, this.connectionMode_,
       this.onProtocolExtensionMessage_.bind(this));
   remoting.clientSession = this.clientSession_;
 
   this.connectedView_ = new remoting.DesktopConnectedView(
       this.plugin_, this.clientContainer_, this.host_,
@@ skipping 135 matching lines @@
       break;
 
     case remoting.ClientSession.State.CLOSED:
       // This class deregisters for state-change callbacks when the CONNECTED
       // state is reached, so it only sees the CLOSED state in exceptional
       // circumstances. For example, a CONNECTING -> CLOSED transition happens
       // if the host closes the connection without an error message instead of
       // accepting it. Since there's no way of knowing exactly what went wrong,
       // we rely on server-side logs in this case and report a generic error
       // message.
-      this.onError_(remoting.Error.UNEXPECTED);
+      this.onError_(remoting.Error.unexpected());
       break;
 
     case remoting.ClientSession.State.FAILED:
       var error = this.clientSession_.getError();
-      console.error('Client plugin reported connection failed: ' + error);
+      console.error('Client plugin reported connection failed: ' +
+                    error.toString());
       if (error == null) {
-        error = remoting.Error.UNEXPECTED;
+        error = remoting.Error.unexpected();
       }
       this.onConnectionFailed_(error);
       break;
 
     default:
       console.error('Unexpected client plugin state: ' + event.current);
       // This should only happen if the web-app and client plugin get out of
       // sync, and even then the version check should ensure compatibility.
-      this.onError_(remoting.Error.MISSING_PLUGIN);
+      this.onError_(new remoting.Error(remoting.Error.Tag.MISSING_PLUGIN));
   }
 };
 
 /**
  * @constructor
  * @implements {remoting.SessionConnectorFactory}
  */
 remoting.DefaultSessionConnectorFactory = function() {};
 
 /**
@@ skipping 16 matching lines @@
     function(clientContainer, onConnected, onError,
              appProtocolExtensionHandler,
              onConnectionFailed, requiredCapabilities, defaultRemapKeys) {
   return new remoting.SessionConnectorImpl(clientContainer, onConnected,
                                            onError,
                                            appProtocolExtensionHandler,
                                            onConnectionFailed,
                                            requiredCapabilities,
                                            defaultRemapKeys);
 };