Updated remoting.xhr API to use promises. Removed access to the native

remoting/webapp/crd/js/oauth2.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * OAuth2 class that handles retrieval/storage of an OAuth2 token.
  *
  * Uses a content script to trampoline the OAuth redirect page back into the
  * extension context.  This works around the lack of native support for
@@ skipping 232 matching lines @@
 /**
  * Redirect page to get a new OAuth2 authorization code
  *
  * @param {function(?string):void} onDone Completion callback to receive
  *     the authorization code, or null on error.
  * @return {void} Nothing.
  */
 remoting.OAuth2.prototype.getAuthorizationCode = function(onDone) {
   var xsrf_token = base.generateXsrfToken();
   var GET_CODE_URL = this.getOAuth2AuthEndpoint_() + '?' +
-    remoting.xhr.urlencodeParamHash({
+    remoting.Xhr.urlencodeParamHash({
           'client_id': this.getClientId_(),
           'redirect_uri': this.getRedirectUri_(),
           'scope': this.SCOPE_,
           'state': xsrf_token,
           'response_type': 'code',
           'access_type': 'offline',
           'approval_prompt': 'force'
         });
 
   /**
@@ skipping 52 matching lines @@
 /**
  * Asynchronously exchanges an authorization code for a refresh token.
  *
  * @param {string} code The OAuth2 authorization code.
  * @param {function():void} onDone Callback to invoke on completion.
  * @return {void} Nothing.
  */
 remoting.OAuth2.prototype.exchangeCodeForToken = function(code, onDone) {
   /** @param {!remoting.Error} error */
   var onError = function(error) {
-    console.error('Unable to exchange code for token: ', error);
+    console.error('Unable to exchange code for token: ' + error.toString());
   };
 
   remoting.oauth2Api.exchangeCodeForTokens(
       this.onTokens_.bind(this, onDone), onError,
       this.getClientId_(), this.getClientSecret_(), code,
       this.getRedirectUri_());
 };
 
 /**
  * Print a command-line that can be used to register a host on Linux platforms.
@@ skipping 31 matching lines @@
     if (refreshToken) {
       if (that.needsNewAccessToken_()) {
         remoting.oauth2Api.refreshAccessToken(
             that.onAccessToken_.bind(that, resolve), reject,
             that.getClientId_(), that.getClientSecret_(),
             refreshToken);
       } else {
         resolve(that.getAccessTokenInternal_()['token']);
       }
     } else {
-      reject(remoting.Error.NOT_AUTHENTICATED);
+      reject(new remoting.Error(remoting.Error.Tag.NOT_AUTHENTICATED));
     }
   });
 };
 
 /**
  * Get the user's email address.
  *
  * @return {!Promise<string>} Promise resolved with the user's email
  *     address or rejected with a remoting.Error.
  */
@@ skipping 52 matching lines @@
       window.localStorage.setItem(that.KEY_FULLNAME_, name);
       resolve({email: email, name: name});
     };
 
     that.getToken().then(
         remoting.oauth2Api.getUserInfo.bind(
             remoting.oauth2Api, onResponse, reject),
         reject);
   });
 };