Updated remoting.xhr API to use promises. Removed access to the native

remoting/webapp/crd/js/host_daemon_facade.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class to communicate with the host daemon via Native Messaging.
  */
 
 'use strict';
@@ skipping 24 matching lines @@
   this.afterInitializationTasks_ = [];
 
   /**
    * A promise that fulfills when the daemon finishes initializing.
    * It will be set to null when the promise fulfills.
    * @private {Promise}
    */
   this.initializingPromise_ = null;
 
   /** @private {!remoting.Error} */
-  this.error_ = remoting.Error.NONE;
+  this.error_ = remoting.Error.none();
 
   /** @private */
   this.onIncomingMessageCallback_ = this.onIncomingMessage_.bind(this);
 
   /** @private */
   this.onDisconnectCallback_ = this.onDisconnect_.bind(this);
 
   this.initialize_();
 };
 
@@ skipping 143 matching lines @@
   delete this.pendingReplies_[id];
 
   try {
     var type = getStringAttr(message, 'type');
     if (type != reply.type) {
       throw 'Expected reply type: ' + reply.type + ', got: ' + type;
     }
 
     this.handleIncomingMessage_(message, reply.onDone);
   } catch (/** @type {*} */ e) {
-    console.error('Error while processing native message' + e);
-    reply.onError(remoting.Error.UNEXPECTED);
+    console.error('Error while processing native message', e);
+    reply.onError(remoting.Error.unexpected());
   }
 }
 
 /**
  * Handler for incoming Native Messages.
  *
  * @param {Object} message The received message.
  * @param {function(...):void} onDone Function to call when we're done
  *     processing the message.
  * @return {void} Nothing.
@@ skipping 96 matching lines @@
  */
 remoting.HostDaemonFacade.prototype.onDisconnect_ = function() {
   console.error('Native Message port disconnected');
 
   this.port_.onDisconnect.removeListener(this.onDisconnectCallback_);
   this.port_.onMessage.removeListener(this.onIncomingMessageCallback_);
   this.port_ = null;
 
   // If initialization hasn't finished then assume that the port was
   // disconnected because Native Messaging host is not installed.
-  this.error_ = this.initializingPromise_ ? remoting.Error.MISSING_PLUGIN :
-                                            remoting.Error.UNEXPECTED;
+  this.error_ = this.initializingPromise_ ?
+      new remoting.Error(remoting.Error.Tag.MISSING_PLUGIN) :
+      remoting.Error.unexpected();
 
   // Notify the error-handlers of any requests that are still outstanding.
   var pendingReplies = this.pendingReplies_;
   this.pendingReplies_ = {};
   for (var id in pendingReplies) {
     var num_id = parseInt(id, 10);
     pendingReplies[num_id].onError(this.error_);
   }
 }
 
@@ skipping 212 matching lines @@
  * @param {function(!remoting.Error):void} onError Callback to call on error.
  * @return {void} Nothing.
  */
 remoting.HostDaemonFacade.prototype.getCredentialsFromAuthCode =
     function(authorizationCode, onDone, onError) {
   this.postMessage_({
     type: 'getCredentialsFromAuthCode',
     authorizationCode: authorizationCode
   }, onDone, onError);
 };