Updated remoting.xhr API to use promises. Removed access to the native

remoting/webapp/crd/js/crd_connect.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Functions related to the 'client screen' for Chromoting.
  */
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * Initiate an IT2Me connection.
  */
 remoting.connectIT2Me = function() {
   var connector = remoting.app.getSessionConnector();
   var accessCode = document.getElementById('access-code-entry').value;
   remoting.setMode(remoting.AppMode.CLIENT_CONNECTING);
   remoting.It2MeConnectFlow.start(connector, accessCode).
-    catch(function(/** remoting.Error */ reason){
+    catch(function(/** !remoting.Error */ reason){
       var errorDiv = document.getElementById('connect-error-message');
-      l10n.localizeElementFromTag(errorDiv, reason.tag);
+      l10n.localizeElementFromTag(errorDiv, reason.getTag());
       remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
   });
 };
 
 /**
  * Entry-point for Me2Me connections, handling showing of the host-upgrade nag
  * dialog if necessary.
  *
  * @param {string} hostId The unique id of the host.
  * @return {void} Nothing.
  */
 remoting.connectMe2Me = function(hostId) {
   var host = remoting.hostList.getHostForId(hostId);
   if (!host) {
-    remoting.app.onError(remoting.Error.HOST_IS_OFFLINE);
+    remoting.app.onError(new remoting.Error(
+        remoting.Error.Tag.HOST_IS_OFFLINE));
     return;
   }
   var webappVersion = chrome.runtime.getManifest().version;
   var needsUpdateDialog = new remoting.HostNeedsUpdateDialog(
       document.getElementById('host-needs-update-dialog'), host);
 
   needsUpdateDialog.showIfNecessary(webappVersion).then(function() {
     remoting.connectMe2MeHostVersionAcknowledged_(host);
   }).catch(function(/** remoting.Error */ error) {
-    if (error.tag === remoting.Error.Tag.CANCELLED) {
+    if (error.hasTag(remoting.Error.Tag.CANCELLED)) {
       remoting.setMode(remoting.AppMode.HOME);
     }
   });
 };
 
 /**
  * Shows PIN entry screen localized to include the host name, and registers
  * a host-specific one-shot event handler for the form submission.
  *
  * @param {remoting.Host} host The Me2Me host to which to connect.
@@ skipping 42 matching lines @@
     if (pairingInfo) {
       clientId = /** @type {string} */ (pairingInfo['clientId']);
       sharedSecret = /** @type {string} */ (pairingInfo['sharedSecret']);
     }
     connector.connectMe2Me(host, requestPin, fetchThirdPartyToken,
                                  clientId, sharedSecret);
   }
 
   remoting.HostSettings.load(host.hostId, connectMe2MeHostSettingsRetrieved);
 };