chrome/browser/ui/app_list/extension_app_model_builder.cc - Issue 1003393002: After uninstall, remove last item in Launcher folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder.cc

Issue 1003393002: After uninstall, remove last item in Launcher folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move work from views to model, as per reviewer comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/app_list/extension_app_model_builder.cc

diff --git a/chrome/browser/ui/app_list/extension_app_model_builder.cc b/chrome/browser/ui/app_list/extension_app_model_builder.cc

index 2bac8c768b06ffcbd1757b0fbf075344e84effd9..7384fcbc69a9d33978fb0f09c425cc218496e339 100644

--- a/chrome/browser/ui/app_list/extension_app_model_builder.cc

+++ b/chrome/browser/ui/app_list/extension_app_model_builder.cc

@@ -205,10 +205,10 @@ void ExtensionAppModelBuilder::OnExtensionUninstalled(

if (service_) {

DVLOG(2) << service_ << ": OnExtensionUninstalled: "

<< extension->id().substr(0, 8);

- service_->RemoveItem(extension->id());

+ service_->RemoveUninstalledItem(extension->id());

return;

}

- model_->DeleteItem(extension->id());

+ model_->DeleteUninstalledItem(extension->id());

}

void ExtensionAppModelBuilder::OnDisabledExtensionUpdated(

« no previous file with comments | « chrome/browser/ui/app_list/app_list_syncable_service.cc ('k') | ui/app_list/app_list_model.h » ('j') | ui/app_list/app_list_model.h » ('J')