Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1003383004: Fix the V8_GNUC_PREREQ macro. (Closed)

Created:
5 years, 9 months ago by Alexandre Rames
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the V8_GNUC_PREREQ macro. BUG= Committed: https://crrev.com/fc7ff65c6d8d1b75ad904ddea95110e91db2b987 Cr-Commit-Position: refs/heads/master@{#27442}

Patch Set 1 #

Patch Set 2 : Fix spaces messed up by the formatter #

Patch Set 3 : Fix one more whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/v8config.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Alexandre Rames
5 years, 9 months ago (2015-03-25 13:39:25 UTC) #2
Alexandre Rames
5 years, 9 months ago (2015-03-25 13:42:15 UTC) #3
Sven Panne
Drive-by LGTM...
5 years, 9 months ago (2015-03-25 13:48:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003383004/40001
5 years, 9 months ago (2015-03-25 13:48:53 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-25 14:22:31 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 14:22:44 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc7ff65c6d8d1b75ad904ddea95110e91db2b987
Cr-Commit-Position: refs/heads/master@{#27442}

Powered by Google App Engine
This is Rietveld 408576698