Add presubmit check for copyright notice

Add copyright check to PRESUBMIT

BUG=skia:1724
Committed: https://skia.googlesource.com/skia/+/c7c91806e35da06b13394262d83c169a83f76b1d

[borenet, 2015-03-23 14:38:04]

borenet@google.com changed reviewers:
+ mtklein@google.com, rmistry@google.com

[borenet, 2015-03-23 14:38:05]

https://codereview.chromium.org/1003363005/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1003363005/diff/1/PRESUBMIT.py#newcode137
PRESUBMIT.py:137: 'The Native Client Authors. All rights reserved.',
I just pulled these from existing copyright notices.  Are these all valid? 
Should I just check that there's a copyright notice at all, rather than having
an owner whitelist?  For that matter, there are a few files which have no
copyright owner, ie. "Copyright 2014".  Is that valid?

[rmistry, 2015-03-23 14:48:44]

There is also some code that does the copyright check in depot_tools.
presubmit_canned_checks.PanProjectChecks and
presubmit_canned_checks.CheckLicense.

[mtklein, 2015-03-23 14:49:50]

Oh man, I really need this.

https://codereview.chromium.org/1003363005/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1003363005/diff/1/PRESUBMIT.py#newcode137
PRESUBMIT.py:137: 'The Native Client Authors. All rights reserved.',
On 2015/03/23 14:38:05, borenet wrote:
> I just pulled these from existing copyright notices.  Are these all valid? 
> Should I just check that there's a copyright notice at all, rather than having
> an owner whitelist?  For that matter, there are a few files which have no
> copyright owner, ie. "Copyright 2014".  Is that valid?

Let's both exclude third_party ('Lua.org, PUC-Rio') and allow any non-empty
copyright holder ([^\w]+) ?

[borenet, 2015-03-23 17:20:35]

Ravi, I looked into the checks in depot_tools, and it looks like I'd have to go
ahead and pass in the same regex anyway.  Not sure it's worth it.

https://codereview.chromium.org/1003363005/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1003363005/diff/1/PRESUBMIT.py#newcode137
PRESUBMIT.py:137: 'The Native Client Authors. All rights reserved.',
On 2015/03/23 14:49:50, mtklein wrote:
> On 2015/03/23 14:38:05, borenet wrote:
> > I just pulled these from existing copyright notices.  Are these all valid? 
> > Should I just check that there's a copyright notice at all, rather than
having
> > an owner whitelist?  For that matter, there are a few files which have no
> > copyright owner, ie. "Copyright 2014".  Is that valid?
> 
> Let's both exclude third_party ('Lua.org, PUC-Rio') and allow any non-empty
> copyright holder ([^\w]+) ?

Done.

[borenet, 2015-03-24 18:18:48]

Friendly ping.

[rmistry, 2015-03-24 18:27:36]

On 2015/03/24 18:18:48, borenet wrote:
> Friendly ping.

LGTM if it LGT-Mike

[mtklein, 2015-03-24 20:47:50]

LGTM too

[borenet, 2015-03-25 11:41:32]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-03-25 11:41:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1003363005/40001

[commit-bot: I haz the power, 2015-03-25 11:47:07]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c7c91806e35da06b13394262d83c169a83f76b1d