Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1003363003: Serializer: cache hashmaps on the isolate. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: cache hashmaps on the isolate. This speeds up multiple uses of the serializer quite a bit. R=mvstanton@chromium.org Committed: https://crrev.com/2a440ef46a9b84463b67c92bde74a1821dedef92 Cr-Commit-Position: refs/heads/master@{#27340}

Patch Set 1 #

Patch Set 2 : remove bogus test. rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M src/heap/heap.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/isolate.cc View 1 3 chunks +12 lines, -3 lines 0 comments Download
M src/serialize.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/serialize.cc View 1 5 chunks +17 lines, -11 lines 0 comments Download
M src/snapshot-source-sink.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 9 months ago (2015-03-19 14:42:27 UTC) #1
mvstanton
lgtm
5 years, 9 months ago (2015-03-20 10:54:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003363003/20001
5 years, 9 months ago (2015-03-20 10:55:09 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 11:17:15 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 11:17:33 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a440ef46a9b84463b67c92bde74a1821dedef92
Cr-Commit-Position: refs/heads/master@{#27340}

Powered by Google App Engine
This is Rietveld 408576698