Fix ODR violation for ShowTaskManager() on Mac

Fix ODR violation for ShowTaskManager() on Mac

Both task_manager_view and task_manager_cocoa define ShowTaskManager(Browser*).
http://crrev.com/987483003 mistakenly causes both to get linked
when building for Mac. This patch undoes that by moving the task
manager files to Cocoa and Views sources. They are no longer inside
enabled_task_manager condition check, but they are still excluded
from Android this way.

BUG=425229
Committed: https://crrev.com/c5f30f8ca795c18e12a5c5ccac4a8c23134e3ca4
Cr-Commit-Position: refs/heads/master@{#322233}

[Andre, 2015-03-25 18:24:45]

andresantoso@chromium.org changed reviewers:
+ tapted@chromium.org, thakis@chromium.org

[Andre, 2015-03-25 18:24:46]

Nico, Trent, please review

[tapted, 2015-03-25 18:38:03]

lgtm I'd just append "for ShowTaskManager() on Mac" to the CL subject/summary
line for a bit more clarity.

[Nico, 2015-03-25 18:43:50]

rs-lgtm for the code, but I don't fully understand the CL description.

"""
Both task_manager_view and task_manager_cocoa define ShowTaskManager(Browser*).
After http://crrev.com/987483003, both are linked when building for Mac.
This patch corrects that problem by moving the files to Cocoa and Views sources.
The intent is to not include task manager files when building Android
"""

…is that supposed to mean that http://crrev.com/987483003 changed this
accidentally, and that this CL undoes that, while still not building them on
android? If so, that could maybe a bit clearer. (browser/ui/views files are
stilled filtered out on mac, right? Us enabling views only meant that we now
link in ui/views, not any browser stuff built on top of it?)

[Andre, 2015-03-25 20:11:57]

On 2015/03/25 18:38:03, tapted (travelling) wrote:
> lgtm I'd just append "for ShowTaskManager() on Mac" to the CL subject/summary
> line for a bit more clarity.

Done.

[Andre, 2015-03-25 20:13:31]

On 2015/03/25 18:43:50, Nico wrote:
> rs-lgtm for the code, but I don't fully understand the CL description.
> 
> """
> Both task_manager_view and task_manager_cocoa define
ShowTaskManager(Browser*).
> After http://crrev.com/987483003, both are linked when building for Mac.
> This patch corrects that problem by moving the files to Cocoa and Views
sources.
> The intent is to not include task manager files when building Android
> """
> 
> …is that supposed to mean that http://crrev.com/987483003 changed this
> accidentally, and that this CL undoes that, while still not building them on
> android? If so, that could maybe a bit clearer. (browser/ui/views files are
> stilled filtered out on mac, right? Us enabling views only meant that we now
> link in ui/views, not any browser stuff built on top of it?)

That's correct, I've changed the CL description to be clearer.
browser/ui/views are still filtered out on mac, unless the experimental flag
mac_views_browser is set.

[Andre, 2015-03-25 20:13:36]

The CQ bit was checked by andresantoso@chromium.org

[Nico, 2015-03-25 20:13:54]

On 2015/03/25 20:13:31, Andre wrote:
> On 2015/03/25 18:43:50, Nico wrote:
> > rs-lgtm for the code, but I don't fully understand the CL description.
> > 
> > """
> > Both task_manager_view and task_manager_cocoa define
> ShowTaskManager(Browser*).
> > After http://crrev.com/987483003, both are linked when building for Mac.
> > This patch corrects that problem by moving the files to Cocoa and Views
> sources.
> > The intent is to not include task manager files when building Android
> > """
> > 
> > …is that supposed to mean that http://crrev.com/987483003 changed this
> > accidentally, and that this CL undoes that, while still not building them on
> > android? If so, that could maybe a bit clearer. (browser/ui/views files are
> > stilled filtered out on mac, right? Us enabling views only meant that we now
> > link in ui/views, not any browser stuff built on top of it?)
> 
> That's correct, I've changed the CL description to be clearer.
> browser/ui/views are still filtered out on mac, unless the experimental flag
> mac_views_browser is set.

Thanks, now even I get it :-)

[commit-bot: I haz the power, 2015-03-25 20:14:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1003323005/1

[commit-bot: I haz the power, 2015-03-25 20:50:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-25 20:51:53]

Patchset 1 (id:??) landed as
https://crrev.com/c5f30f8ca795c18e12a5c5ccac4a8c23134e3ca4
Cr-Commit-Position: refs/heads/master@{#322233}