Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1003303003: Files.app: Suppress error about removing a non-existent menu item. (Closed)

Created:
5 years, 9 months ago by fukino
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Suppress error about removing a non-existent menu item. As there's no API to know existence of certain menu item, we have to try removing non-existent menu item. Outputting error on console for such case is confusing, so this CL suppress the error by reading runtime.lastError. BUG=none TEST=none Committed: https://crrev.com/6ef076cdc5a9f66ce27e8c529f9b166b747344f9 Cr-Commit-Position: refs/heads/master@{#321288}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Do not output the log. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/file_manager/file_manager/background/js/background.js View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
fukino
Could you take a look? This suppresses the usual error on background script.
5 years, 9 months ago (2015-03-18 11:47:47 UTC) #2
hirono
lgtm! https://codereview.chromium.org/1003303003/diff/1/ui/file_manager/file_manager/background/js/background.js File ui/file_manager/file_manager/background/js/background.js (right): https://codereview.chromium.org/1003303003/diff/1/ui/file_manager/file_manager/background/js/background.js#newcode622 ui/file_manager/file_manager/background/js/background.js:622: console.log(chrome.runtime.lastError.message); nit: I think we even don't need ...
5 years, 9 months ago (2015-03-18 12:25:37 UTC) #3
fukino
Thank you! https://codereview.chromium.org/1003303003/diff/1/ui/file_manager/file_manager/background/js/background.js File ui/file_manager/file_manager/background/js/background.js (right): https://codereview.chromium.org/1003303003/diff/1/ui/file_manager/file_manager/background/js/background.js#newcode622 ui/file_manager/file_manager/background/js/background.js:622: console.log(chrome.runtime.lastError.message); On 2015/03/18 12:25:37, hirono wrote: > ...
5 years, 9 months ago (2015-03-19 03:35:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003303003/20001
5 years, 9 months ago (2015-03-19 03:36:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 04:06:52 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 04:07:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ef076cdc5a9f66ce27e8c529f9b166b747344f9
Cr-Commit-Position: refs/heads/master@{#321288}

Powered by Google App Engine
This is Rietveld 408576698