Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1003273007: LLVM_LTO support for make / ninja (Closed)

Created:
5 years, 9 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
pcc1, scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : ninja, make/mac: Add support for LLVM_LTO. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 1 chunk +8 lines, -0 lines 1 comment Download
A test/mac/gyptest-lto.py View 1 1 chunk +67 lines, -0 lines 1 comment Download
A test/mac/lto/asmfile.S View 1 1 chunk +2 lines, -0 lines 0 comments Download
A test/mac/lto/ccfile.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/lto/cfile.c View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/lto/mfile.m View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/lto/mmfile.mm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pcc
Any plans to submit this? I'm working on a patch to add some LTO-related flags ...
5 years, 8 months ago (2015-03-31 00:46:37 UTC) #1
Nico
Sure, let's land this. I added a test. Looks like the code was already correct. ...
5 years, 8 months ago (2015-04-01 23:32:55 UTC) #3
Nico
I'm out until monday. If you like this, feel free to cq+ and then roll ...
5 years, 8 months ago (2015-04-01 23:42:19 UTC) #4
pcc1
On 2015/04/01 23:42:19, Nico (again away until Monday) wrote: > I'm out until monday. If ...
5 years, 8 months ago (2015-04-01 23:45:56 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 8 months ago (2015-04-01 23:47:16 UTC) #8
Nico
Committed patchset #2 (id:20001) manually as 69dfb493a22f2489a226924425ba0d72eed3f439.
5 years, 8 months ago (2015-04-01 23:49:52 UTC) #9
scottmg
is there an lto/test.gyp missing? https://codereview.chromium.org/1003273007/diff/20001/pylib/gyp/xcode_emulation.py File pylib/gyp/xcode_emulation.py (right): https://codereview.chromium.org/1003273007/diff/20001/pylib/gyp/xcode_emulation.py#newcode534 pylib/gyp/xcode_emulation.py:534: nit; extra \n https://codereview.chromium.org/1003273007/diff/20001/test/mac/gyptest-lto.py ...
5 years, 8 months ago (2015-04-01 23:50:21 UTC) #11
Nico
5 years, 8 months ago (2015-04-01 23:52:39 UTC) #12
Message was sent while issue was closed.
too late!

addressing that at https://codereview.chromium.org/1057723002/

(already did the newline in the last commit)

Powered by Google App Engine
This is Rietveld 408576698