Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/instrumented_libraries/instrumented_libraries.gyp

Issue 1003273006: Re-land: Instrumented libraries: add a target for pre-built libraries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/instrumented_libraries/scripts/unpack_binaries.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/instrumented_libraries/instrumented_libraries.gyp
diff --git a/third_party/instrumented_libraries/instrumented_libraries.gyp b/third_party/instrumented_libraries/instrumented_libraries.gyp
index 28fa65f6c8b582ac119a85d74dd2d3c0df8974e7..2d61a3b22726c2a4f23df9d27af139724529ad70 100644
--- a/third_party/instrumented_libraries/instrumented_libraries.gyp
+++ b/third_party/instrumented_libraries/instrumented_libraries.gyp
@@ -82,6 +82,57 @@
'targets': [
{
+ 'target_name': 'prebuilt_instrumented_libraries',
+ 'type': 'none',
+ 'variables': {
+ 'prune_self_dependency': 1,
+ # Don't add this target to the dependencies of targets with type=none.
+ 'link_dependency': 1,
+ 'conditions': [
+ ['msan==1', {
+ 'conditions': [
+ ['msan_track_origins==2', {
+ 'archive_name': 'msan-chained-origins-<(_ubuntu_release)',
+ }, {
+ 'archive_name': 'UNSUPPORTED_CONFIGURATION'
+ }],
+ ]}, {
+ 'archive_name': 'UNSUPPORTED_CONFIGURATION'
+ }],
+ ],
+ },
+ 'actions': [
+ {
+ 'action_name': 'unpack_<(archive_name).tgz',
+ 'inputs': [
+ 'binaries/<(archive_name).tgz',
+ ],
+ 'outputs': [
+ '<(PRODUCT_DIR)/instrumented_libraries_prebuilt/<(archive_name).txt',
+ ],
+ 'action': [
+ 'scripts/unpack_binaries.sh',
+ 'binaries/<(archive_name).tgz',
+ '<(PRODUCT_DIR)/instrumented_libraries_prebuilt/',
+ '<(PRODUCT_DIR)/instrumented_libraries_prebuilt/<(archive_name).txt',
+ ],
+ },
+ ],
+ 'direct_dependent_settings': {
+ 'target_conditions': [
+ ['_toolset=="target"', {
+ 'ldflags': [
+ # Add a relative RPATH entry to Chromium binaries. This puts
+ # instrumented DSOs before system-installed versions in library
+ # search path.
+ '-Wl,-R,\$$ORIGIN/instrumented_libraries_prebuilt/<(_sanitizer_type)/<(_libdir)/',
+ '-Wl,-z,origin',
+ ],
+ }],
+ ],
+ },
+ },
+ {
'target_name': 'instrumented_libraries',
'type': 'none',
'variables': {
@@ -174,7 +225,9 @@
'target_conditions': [
['_toolset=="target"', {
'ldflags': [
- # Add RPATH to result binary to make it linking instrumented libraries ($ORIGIN means relative RPATH)
+ # Add a relative RPATH entry to Chromium binaries. This puts
+ # instrumented DSOs before system-installed versions in library
+ # search path.
'-Wl,-R,\$$ORIGIN/instrumented_libraries/<(_sanitizer_type)/<(_libdir)/',
'-Wl,-z,origin',
],
« no previous file with comments | « build/common.gypi ('k') | third_party/instrumented_libraries/scripts/unpack_binaries.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698