Issue 1003273005: Synchronize SVGLengthMode values for SVGTextPathElement.startOffset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1003273005: Synchronize SVGLengthMode values for SVGTextPathElement.startOffset (Closed)

Created:
5 years, 9 months ago by fs

Modified:
5 years, 9 months ago

Reviewers:
Erik Dahlström (inactive)

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Synchronize SVGLengthMode values for SVGTextPathElement.startOffset The SVGLengthMode was specified as 'Other' on the attribute, and 'Width' in SVGLength::lengthModeForAnimatedLengthAttribute. Since they are both "wrong" (percentage for this attribute should be resolved against the length of the path it's used for), randomly pick 'Width'. BUG=469620 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192367

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -1 line)			Patch
A +	LayoutTests/svg/animations/animate-startoffset-unitmode.html	View	1 chunk	+3 lines, -1 line	0 comments	Download
A +	LayoutTests/svg/animations/animate-startoffset-unitmode-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/svg/SVGTextPathElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003273005/1

5 years, 9 months ago (2015-03-23 14:25:49 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-23 15:32:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192367

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages