Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1003273005: Synchronize SVGLengthMode values for SVGTextPathElement.startOffset (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Synchronize SVGLengthMode values for SVGTextPathElement.startOffset The SVGLengthMode was specified as 'Other' on the attribute, and 'Width' in SVGLength::lengthModeForAnimatedLengthAttribute. Since they are both "wrong" (percentage for this attribute should be resolved against the length of the path it's used for), randomly pick 'Width'. BUG=469620 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A + LayoutTests/svg/animations/animate-startoffset-unitmode.html View 1 chunk +3 lines, -1 line 0 comments Download
A + LayoutTests/svg/animations/animate-startoffset-unitmode-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 9 months ago (2015-03-23 14:13:28 UTC) #2
Erik Dahlström (inactive)
lgtm
5 years, 9 months ago (2015-03-23 14:19:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003273005/1
5 years, 9 months ago (2015-03-23 14:25:49 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 15:32:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192367

Powered by Google App Engine
This is Rietveld 408576698