Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1003243002: [DevTools] Cleanup after reversing emulation flow. (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Cleanup after reversing emulation flow. BUG=466598 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191930

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -255 lines) Patch
M Source/core/inspector/InspectorPageAgent.h View 1 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 6 chunks +0 lines, -129 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/DevToolsEmulator.h View 1 4 chunks +0 lines, -16 lines 0 comments Download
M Source/web/DevToolsEmulator.cpp View 1 8 chunks +14 lines, -70 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 3 chunks +0 lines, -12 lines 0 comments Download
M Source/web/WebViewImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M public/web/WebDevToolsAgentClient.h View 1 chunk +0 lines, -6 lines 0 comments Download
M public/web/WebView.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dgozman
Please take a look.
5 years, 9 months ago (2015-03-13 16:54:46 UTC) #2
pfeldman
lgtm
5 years, 9 months ago (2015-03-13 17:19:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003243002/20001
5 years, 9 months ago (2015-03-16 14:13:20 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 15:52:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191930

Powered by Google App Engine
This is Rietveld 408576698