Issue 100323003: Remove SkPdfNativeDoc::tokenizerOfStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100323003: Remove SkPdfNativeDoc::tokenizerOfStream. (Closed)

Created:
7 years ago by scroggo

Modified:
7 years ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Remove SkPdfNativeDoc::tokenizerOfStream. Instead, initialize an SkPdfNativeTokenizer directly on the stack. Fixes a memory leak in SkPdfFont. R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=12462

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -37 lines)			Patch
M	experimental/PdfViewer/SkPdfFont.cpp	View	5 chunks	+19 lines, -19 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	experimental/PdfViewer/src/SkPdfContext.cpp	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r12462 (presubmit successful).