Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3693)

Unified Diff: chrome/browser/renderer_host/resource_message_filter.cc

Issue 100321: Track which NativeViewIds each render process is allowed to interact with. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/resource_message_filter.cc
===================================================================
--- chrome/browser/renderer_host/resource_message_filter.cc (revision 14874)
+++ chrome/browser/renderer_host/resource_message_filter.cc (working copy)
@@ -17,6 +17,7 @@
#include "chrome/browser/profile.h"
#include "chrome/browser/renderer_host/audio_renderer_host.h"
#include "chrome/browser/renderer_host/browser_render_process_host.h"
+#include "chrome/browser/renderer_host/renderer_security_policy.h"
#include "chrome/browser/renderer_host/render_widget_helper.h"
#include "chrome/browser/spellchecker.h"
#include "chrome/browser/worker_host/worker_service.h"
@@ -480,6 +481,12 @@
#if !defined(OS_LINUX)
void ResourceMessageFilter::OnGetScreenInfo(gfx::NativeViewId view,
IPC::Message* reply_msg) {
+ RendererSecurityPolicy* policy = RendererSecurityPolicy::GetInstance();
+ if (!policy->HasNativeViewId(GetProcessId(), view)) {
+ NOTREACHED() << "Bad NativeViewId from render process.";
+ return;
+ }
+
// TODO(darin): Change this into a routed message so that we can eliminate
// the NativeViewId parameter.
WebScreenInfo results =
@@ -680,6 +687,12 @@
int cookie,
int expected_pages_count,
IPC::Message* reply_msg) {
+ RendererSecurityPolicy* policy = RendererSecurityPolicy::GetInstance();
+ if (!policy->HasNativeViewId(GetProcessId(), host_window_id)) {
+ NOTREACHED() << "Bad NativeViewId from render process.";
+ return;
+ }
+
HWND host_window = gfx::NativeViewFromId(host_window_id);
scoped_refptr<printing::PrinterQuery> printer_query;
« no previous file with comments | « chrome/browser/renderer_host/renderer_security_policy.cc ('k') | chrome/browser/renderer_host/resource_message_filter_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698