Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4748)

Unified Diff: chrome/browser/renderer_host/resource_message_filter_mac.mm

Issue 100321: Track which NativeViewIds each render process is allowed to interact with. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/resource_message_filter_mac.mm
===================================================================
--- chrome/browser/renderer_host/resource_message_filter_mac.mm (revision 14874)
+++ chrome/browser/renderer_host/resource_message_filter_mac.mm (working copy)
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/renderer_host/renderer_security_policy.h"
#include "chrome/browser/renderer_host/resource_message_filter.h"
#include "chrome/common/render_messages.h"
@@ -25,6 +26,12 @@
void ResourceMessageFilter::OnGetWindowRect(gfx::NativeViewId window_id,
IPC::Message* reply_msg) {
+ RendererSecurityPolicy* policy = RendererSecurityPolicy::GetInstance();
+ if (!policy->HasNativeViewId(GetProcessId(), window_id)) {
+ NOTREACHED() << "Bad NativeViewId from render process.";
+ return;
+ }
+
NSView* view = gfx::NativeViewFromId(window_id);
gfx::Rect rect;
@@ -41,6 +48,12 @@
void ResourceMessageFilter::OnGetRootWindowRect(gfx::NativeViewId window_id,
IPC::Message* reply_msg) {
+ RendererSecurityPolicy* policy = RendererSecurityPolicy::GetInstance();
+ if (!policy->HasNativeViewId(GetProcessId(), window_id)) {
+ NOTREACHED() << "Bad NativeViewId from render process.";
+ return;
+ }
+
NSView* view = gfx::NativeViewFromId(window_id);
gfx::Rect rect;
if (view) {

Powered by Google App Engine
This is Rietveld 408576698