Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1003163003: Autofill: Search for standalone label tags while looking through divs. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Search for standalone label tags while looking through divs. Some websites use labels, but do not wrap inputs in labels and/or do not add the proper for= attribute. Also add a failing test case, which this CL improves upon. BUG=465587 Committed: https://crrev.com/69ca66410b63d9fd7ce1ef620541783233349362 Cr-Commit-Position: refs/heads/master@{#320860}

Patch Set 1 : before #

Patch Set 2 : after #

Total comments: 2

Patch Set 3 : rebase, correspondingControl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -5 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/input/bug_465587.html View 1 chunk +274 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_aol.com.out View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/14_register_trueblue.jetblue.com.out View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/22_checkout_m_kohls.com.out View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/autofill/heuristics/output/bug_465587.out View 1 1 chunk +31 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 2 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Lei Zhang
5 years, 9 months ago (2015-03-14 00:09:51 UTC) #3
Evan Stade
https://codereview.chromium.org/1003163003/diff/40001/components/autofill/content/renderer/form_autofill_util.cc File components/autofill/content/renderer/form_autofill_util.cc (right): https://codereview.chromium.org/1003163003/diff/40001/components/autofill/content/renderer/form_autofill_util.cc#newcode428 components/autofill/content/renderer/form_autofill_util.cc:428: // is to ignore <label for="valid_id"> since those are ...
5 years, 9 months ago (2015-03-16 23:35:36 UTC) #4
Lei Zhang
https://codereview.chromium.org/1003163003/diff/40001/components/autofill/content/renderer/form_autofill_util.cc File components/autofill/content/renderer/form_autofill_util.cc (right): https://codereview.chromium.org/1003163003/diff/40001/components/autofill/content/renderer/form_autofill_util.cc#newcode428 components/autofill/content/renderer/form_autofill_util.cc:428: // is to ignore <label for="valid_id"> since those are ...
5 years, 9 months ago (2015-03-17 00:23:37 UTC) #5
Evan Stade
lgtm
5 years, 9 months ago (2015-03-17 01:42:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003163003/60001
5 years, 9 months ago (2015-03-17 02:15:36 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-17 04:28:46 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 04:29:26 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/69ca66410b63d9fd7ce1ef620541783233349362
Cr-Commit-Position: refs/heads/master@{#320860}

Powered by Google App Engine
This is Rietveld 408576698