Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100313005: Add cast to fix Win* compile complaint/failure (Closed)

Created:
7 years ago by robertphillips
Modified:
7 years ago
Reviewers:
tomhudson, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add cast to fix Win* compile complaint/failure TBR=tomhudson@google.com Committed: http://code.google.com/p/skia/source/detail?r=12764

Patch Set 1 #

Patch Set 2 : Switch from push a scalar to pushing a U32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/utils/SkLua.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
committed as r12750
7 years ago (2013-12-18 19:02:15 UTC) #1
reed1
seems like textEncoding should be returned to Lua as a (logical) int or, even clearer, ...
7 years ago (2013-12-18 19:06:59 UTC) #2
robertphillips
PTAL. Tom also suggested the U32 fix via chat.
7 years ago (2013-12-18 20:22:50 UTC) #3
tomhudson
On 2013/12/18 20:22:50, robertphillips wrote: > PTAL. Tom also suggested the U32 fix via chat. ...
7 years ago (2013-12-19 10:30:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/100313005/20001
7 years ago (2013-12-19 10:30:49 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-19 10:40:01 UTC) #6
Message was sent while issue was closed. 
Change committed as 12764

Powered by Google App Engine
This is Rietveld 408576698