Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1003073002: Create non-blocked fifo (Closed)

Created:
5 years, 9 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 9 months ago
Reviewers:
Ted C, no sievers
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create non-blocked fifo On average it takes about 459 ms to create a FIFO file for logging. This delay isn't small compared to the average running time (1354 ms) of a single testcase on native. The delay is because currently creating the FIFO file is blocked until the other end is opened also. So changing it to non-blocking will save the amount of time. BUG=449354 Committed: https://crrev.com/159f0e04e089a3a12c9ffc44ea644a3abbc4a7ae Cr-Commit-Position: refs/heads/master@{#320847}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/android/browsertests_apk/content_browser_tests_android.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jaekyun Seok (inactive)
Please take a look at this CL.
5 years, 9 months ago (2015-03-16 02:44:38 UTC) #2
Ted C
lgtm Not sure about the implications, but assuming this works then it's fine with me.
5 years, 9 months ago (2015-03-16 22:19:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003073002/60001
5 years, 9 months ago (2015-03-17 01:27:27 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-17 02:20:05 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 02:20:36 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/159f0e04e089a3a12c9ffc44ea644a3abbc4a7ae
Cr-Commit-Position: refs/heads/master@{#320847}

Powered by Google App Engine
This is Rietveld 408576698