Enable cc_perftests on "Linux Perf (3)".

Enable cc_perftests on "Linux Perf (3)".

BUG=392620
Committed: https://crrev.com/3bc1cbd1bcfb69cf8c72b83914ed630b4788a2a1
Cr-Commit-Position: refs/heads/master@{#320688}

[Daniele Castagna, 2015-03-13 19:03:39]

dcastagna@chromium.org changed reviewers:
+ simonhatch@chromium.org

[qyearsley, 2015-03-13 20:23:14]

Is this all that's required? We were wanting to re-add cc_perftests since quite
a while ago I think: http://crbug.com/392620

Anyway, everything should already be set up for the perf dashboard and bisect to
be able to bisect cc_perftests. It's on the list of monitored tests, so alerts
should start coming again once the tests start running again.

Adrienne: You're currently listed as the test owner for cc_perftests on the perf
dashboard (see https://chromeperf.appspot.com/edit_test_owners), so if perf
sheriffs have questions/concerns about the test after it starts running again,
they may contact you, is that OK?

[sullivan, 2015-03-13 20:28:18]

On 2015/03/13 20:23:14, qyearsley wrote:
> Is this all that's required? We were wanting to re-add cc_perftests since
quite
> a while ago I think: http://crbug.com/392620
> 
> Anyway, everything should already be set up for the perf dashboard and bisect
to
> be able to bisect cc_perftests. It's on the list of monitored tests, so alerts
> should start coming again once the tests start running again.
> 
> Adrienne: You're currently listed as the test owner for cc_perftests on the
perf
> dashboard (see https://chromeperf.appspot.com/edit_test_owners), so if perf
> sheriffs have questions/concerns about the test after it starts running again,
> they may contact you, is that OK?

Simon has made a lot of changes to the recipe so that this should be all that's
required. If not, hopefully he'll catch it in review :)

We are getting some data from gpu_perftests already.

[Daniele Castagna, 2015-03-13 20:30:29]

On 2015/03/13 at 20:23:14, qyearsley wrote:
> Is this all that's required? We were wanting to re-add cc_perftests since
quite a while ago I think: http://crbug.com/392620
> 
> Anyway, everything should already be set up for the perf dashboard and bisect
to be able to bisect cc_perftests. It's on the list of monitored tests, so
alerts should start coming again once the tests start running again.
> 
> Adrienne: You're currently listed as the test owner for cc_perftests on the
perf dashboard (see https://chromeperf.appspot.com/edit_test_owners), so if perf
sheriffs have questions/concerns about the test after it starts running again,
they may contact you, is that OK?

simonhatch@ has been working on this (e.g: crrev.com/873403002,
crrev.com/890653002).

This is the only thing that should be left. We decided I can take over the last
step of adding cc_perftests while I'm already dealing with gpu_perftests.

[Daniele Castagna, 2015-03-13 20:31:28]

On 2015/03/13 at 20:30:29, Daniele Castagna wrote:
> On 2015/03/13 at 20:23:14, qyearsley wrote:
> > Is this all that's required? We were wanting to re-add cc_perftests since
quite a while ago I think: http://crbug.com/392620
> > 
> > Anyway, everything should already be set up for the perf dashboard and
bisect to be able to bisect cc_perftests. It's on the list of monitored tests,
so alerts should start coming again once the tests start running again.
> > 
> > Adrienne: You're currently listed as the test owner for cc_perftests on the
perf dashboard (see https://chromeperf.appspot.com/edit_test_owners), so if perf
sheriffs have questions/concerns about the test after it starts running again,
they may contact you, is that OK?
> 
> simonhatch@ has been working on this (e.g: crrev.com/873403002,
crrev.com/890653002).
> 
> This is the only thing that should be left. We decided I can take over the
last step of adding cc_perftests while I'm already dealing with gpu_perftests.

I'm going to contact the perf sheriffs before landing this.

[enne (OOO), 2015-03-13 21:17:09]

I'm not sure what this means.  Does this imply monitoring and alerts?  Or just
graphs and bisects?

[qyearsley, 2015-03-13 23:59:15]

On 2015/03/13 21:17:09, enne wrote:
> I'm not sure what this means.  Does this imply monitoring and alerts?  Or just
> graphs and bisects?

cc_perftests hasn't been running on chromium.perf since last year, and soon it
should start running again, after which there will once again be graphs,
monitoring and alerts on the perf dashboard for potential compositor performance
regressions.

It's possible that somebody looking at the graphs will have some question about
the tests themselves, or that somebody will notice if the test has higher
variance or stops running. Would it be ok for people to ask you about these
things? Somebody else can also be added as "test owner" for cc_perftests; this
can be done at https://chromeperf.appspot.com/edit_test_owners.

[shatch, 2015-03-15 14:37:58]

On 2015/03/13 20:28:18, sullivan wrote:
> On 2015/03/13 20:23:14, qyearsley wrote:
> > Is this all that's required? We were wanting to re-add cc_perftests since
> quite
> > a while ago I think: http://crbug.com/392620
> > 
> > Anyway, everything should already be set up for the perf dashboard and
bisect
> to
> > be able to bisect cc_perftests. It's on the list of monitored tests, so
alerts
> > should start coming again once the tests start running again.
> > 
> > Adrienne: You're currently listed as the test owner for cc_perftests on the
> perf
> > dashboard (see https://chromeperf.appspot.com/edit_test_owners), so if perf
> > sheriffs have questions/concerns about the test after it starts running
again,
> > they may contact you, is that OK?
> 
> Simon has made a lot of changes to the recipe so that this should be all
that's
> required. If not, hopefully he'll catch it in review :)
> 
> We are getting some data from gpu_perftests already.

There was work involved getting to the point where we could enable them via our
own chromium.perf.json file. It *should* work on Linux/Mac/Android now and I
think needs a bit of work to get going on Windows. I asked Daniele to take over
since he's already doing similar work to get gpu_perftests going.

[shatch, 2015-03-15 14:38:33]

On 2015/03/15 14:37:58, shatch wrote:
> On 2015/03/13 20:28:18, sullivan wrote:
> > On 2015/03/13 20:23:14, qyearsley wrote:
> > > Is this all that's required? We were wanting to re-add cc_perftests since
> > quite
> > > a while ago I think: http://crbug.com/392620
> > > 
> > > Anyway, everything should already be set up for the perf dashboard and
> bisect
> > to
> > > be able to bisect cc_perftests. It's on the list of monitored tests, so
> alerts
> > > should start coming again once the tests start running again.
> > > 
> > > Adrienne: You're currently listed as the test owner for cc_perftests on
the
> > perf
> > > dashboard (see https://chromeperf.appspot.com/edit_test_owners), so if
perf
> > > sheriffs have questions/concerns about the test after it starts running
> again,
> > > they may contact you, is that OK?
> > 
> > Simon has made a lot of changes to the recipe so that this should be all
> that's
> > required. If not, hopefully he'll catch it in review :)
> > 
> > We are getting some data from gpu_perftests already.
> 
> There was work involved getting to the point where we could enable them via
our
> own chromium.perf.json file. It *should* work on Linux/Mac/Android now and I
> think needs a bit of work to get going on Windows. I asked Daniele to take
over
> since he's already doing similar work to get gpu_perftests going.

lgtm, thanks for taking this over

[Daniele Castagna, 2015-03-15 20:24:25]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2015-03-15 20:24:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1003063003/20001

[commit-bot: I haz the power, 2015-03-15 22:35:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-15 22:36:48]

Patchset 2 (id:??) landed as
https://crrev.com/3bc1cbd1bcfb69cf8c72b83914ed630b4788a2a1
Cr-Commit-Position: refs/heads/master@{#320688}