Source/bindings/core/v8/ScriptStreamerTest.cpp - Issue 1003043002: bindings: Use Maybe APIs in V8ScriptRunner (part 1)

Unified Diff: Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 1003043002: bindings: Use Maybe APIs in V8ScriptRunner (part 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptDebugServer.cpp ('K') | « Source/bindings/core/v8/ScriptDebugServer.cpp ('k') | Source/bindings/core/v8/V8BindingMacros.h » ('j') | Source/bindings/core/v8/V8ScriptRunner.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/ScriptStreamerTest.cpp

diff --git a/Source/bindings/core/v8/ScriptStreamerTest.cpp b/Source/bindings/core/v8/ScriptStreamerTest.cpp

index 23c26a8623dc39d447bb15e977629c55a1e15823..be5446adb97d976f8fa7d293b112a23a41d462b5 100644

--- a/Source/bindings/core/v8/ScriptStreamerTest.cpp

+++ b/Source/bindings/core/v8/ScriptStreamerTest.cpp

@@ -163,8 +163,8 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScript)

EXPECT_FALSE(errorOccurred);

EXPECT_TRUE(sourceCode.streamer());

v8::TryCatch tryCatch;

- v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());

- EXPECT_FALSE(script.IsEmpty());

+ v8::Local<v8::Script> script;

+ EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocal(&script));

EXPECT_FALSE(tryCatch.HasCaught());

}

@@ -196,8 +196,8 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScriptWithParseError)

EXPECT_FALSE(errorOccurred);

EXPECT_TRUE(sourceCode.streamer());

v8::TryCatch tryCatch;

- v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());

- EXPECT_TRUE(script.IsEmpty());

+ v8::Local<v8::Script> script;

+ EXPECT_FALSE(V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocal(&script));

EXPECT_TRUE(tryCatch.HasCaught());

}

@@ -327,8 +327,8 @@ TEST_F(ScriptStreamingTest, ScriptsWithSmallFirstChunk)

EXPECT_FALSE(errorOccurred);

EXPECT_TRUE(sourceCode.streamer());

v8::TryCatch tryCatch;

- v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());

- EXPECT_FALSE(script.IsEmpty());

+ v8::Local<v8::Script> script;

+ EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocal(&script));

EXPECT_FALSE(tryCatch.HasCaught());

}

@@ -355,8 +355,8 @@ TEST_F(ScriptStreamingTest, EncodingChanges)

EXPECT_FALSE(errorOccurred);

EXPECT_TRUE(sourceCode.streamer());

v8::TryCatch tryCatch;

- v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());

- EXPECT_FALSE(script.IsEmpty());

+ v8::Local<v8::Script> script;

+ EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocal(&script));

EXPECT_FALSE(tryCatch.HasCaught());

}

@@ -383,8 +383,8 @@ TEST_F(ScriptStreamingTest, EncodingFromBOM)

EXPECT_FALSE(errorOccurred);

EXPECT_TRUE(sourceCode.streamer());

v8::TryCatch tryCatch;

- v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());

- EXPECT_FALSE(script.IsEmpty());

+ v8::Local<v8::Script> script;

+ EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocal(&script));

EXPECT_FALSE(tryCatch.HasCaught());

}