Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 100303005: Ensure that reposting mouse events on Windows posts the message natively via the PostMessage API. (Closed)

Created:
7 years ago by ananta
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Ensure that reposting mouse events on Windows posts the message natively via the PostMessage API. The current code posts the events via the Aura code path which does not work on Windows with the glass theme for the system menu buttons (Min/Max/Restore). These are part of the non client area of the Window and rely on the WM_NCLBUTTONDOWN message to be defproced which eventually posts a WM_SYSCOMMAND message for the corresponding operation. Fix is to check if the NativeWindow doing a repost is in the Metro environment for Windows. If yes we continue the current logic of reposting the events via Aura. If not we post the message natively. The RepostLocatedEvent function internally calls the RepostLocatedEventWin function to post the function natively. The functionality to check if a window is in metro has been added to the ViewsDelegate interface and is implemented by Chrome. Fixes bug https://code.google.com/p/chromium/issues/detail?id=323105 BUG=323105 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238462

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/event_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/event_utils_aura.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/event_utils_win.cc View 1 chunk +6 lines, -1 line 1 comment Download
M ui/views/test/test_views_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
7 years ago (2013-12-03 02:10:41 UTC) #1
sky
https://codereview.chromium.org/100303005/diff/1/ui/views/event_utils_win.cc File ui/views/event_utils_win.cc (right): https://codereview.chromium.org/100303005/diff/1/ui/views/event_utils_win.cc#newcode17 ui/views/event_utils_win.cc:17: bool RepostLocatedEventWin(HWND window, Can't you go with this signature ...
7 years ago (2013-12-03 17:16:45 UTC) #2
sky
I get it, LGTM
7 years ago (2013-12-03 21:37:55 UTC) #3
ananta
7 years ago (2013-12-03 21:46:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r238462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698