Issue 100303004: Use FakeDesktopMediaList for Desktop Capture API tests.

Issue 100303004: Use FakeDesktopMediaList for Desktop Capture API tests. (Closed)

Created:
7 years ago by Sergey Ulanov

Modified:
7 years ago

Reviewers:
Nico, Matt Perry

CC:
chromium-reviews, extensions-reviews_chromium.org, fischman+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use FakeDesktopMediaList for Desktop Capture API tests. Previously the tests were using actual media sources. This change makes the test more reliable as they no longer depend on system resources. Also FakeDesktopMediaList has been moved from desktop_media_picker_controller_unittest.mm to a separate file so it can be reused R=mpcomplete@chromium.org, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238463

Patch Set 1 : #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -92 lines)			Patch
M	chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc	View		5 chunks	+17 lines, -15 lines	0 comments	Download
M	chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc	View	1	3 chunks	+6 lines, -9 lines	0 comments	Download
A	chrome/browser/media/fake_desktop_media_list.h	View		1 chunk	+37 lines, -0 lines	0 comments	Download
A	chrome/browser/media/fake_desktop_media_list.cc	View		1 chunk	+59 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm	View		2 chunks	+1 line, -65 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

+thakis@chromium.org for code removed from chrome/browser/ui/cocoa/media_picker

7 years ago (2013-12-03 02:37:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/100303004/50001

7 years ago (2013-12-03 02:38:11 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195915

7 years ago (2013-12-03 05:57:21 UTC) #5

Sergey Ulanov

7 years ago (2013-12-03 21:55:13 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r238463 (presubmit successful).

Expand Messages | Collapse Messages