Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100303003: Move more uses of string16 to specify base:: (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, cbentzel+watch_chromium.org, James Su, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, dcheng, nona+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Move more uses of string16 to specify base:: This makes base, ui, and net compile without the "using base::string16" directive that's currently checked in. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -478 lines) Patch
M base/containers/hash_tables.h View 1 chunk +1 line, -1 line 0 comments Download
M base/file_version_info.h View 1 chunk +15 lines, -15 lines 0 comments Download
M base/i18n/case_conversion_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M base/i18n/file_util_icu.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/file_util_icu.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/time_formatting.cc View 2 chunks +1 line, -4 lines 0 comments Download
M base/pickle.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/pickle.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/pickle_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/strings/string16.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string16_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M base/strings/string_util.h View 15 chunks +55 lines, -52 lines 0 comments Download
M base/strings/string_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_message_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard.h View 4 chunks +8 lines, -8 lines 0 comments Download
M ui/base/clipboard/clipboard_gtk.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.h View 1 chunk +11 lines, -9 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.cc View 7 chunks +14 lines, -13 lines 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.h View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M ui/base/ime/composition_text.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/text_input_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/l10n/l10n_util.h View 2 chunks +56 lines, -52 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 12 chunks +71 lines, -68 lines 0 comments Download
M ui/base/l10n/l10n_util_collator.h View 4 chunks +11 lines, -10 lines 0 comments Download
M ui/base/l10n/time_format.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/base/l10n/time_format.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/base/text/bytes_formatting.h View 2 chunks +8 lines, -5 lines 0 comments Download
M ui/base/text/bytes_formatting.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/pango_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/render_text.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/text_elider.h View 9 chunks +34 lines, -31 lines 0 comments Download
M ui/gfx/text_elider.cc View 49 chunks +132 lines, -127 lines 0 comments Download
M ui/gfx/utf16_indexing.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/utf16_indexing.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR=sky
7 years ago (2013-12-02 23:44:02 UTC) #1
brettw
7 years ago (2013-12-03 00:39:34 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r238246.

Powered by Google App Engine
This is Rietveld 408576698