Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1002993002: Revert of Resurrect Aura Linux accessibility. (Closed)

Created:
5 years, 9 months ago by alexmos
Modified:
5 years, 9 months ago
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Resurrect Aura Linux accessibility. (patchset #15 id:280001 of https://codereview.chromium.org/975113002/) Reason for revert: Caused compile failure on Linux x64 bot (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/56532) Output snippet: FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a x64 -c unstable dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory. 2a3 > libatk1.0-0 (>= 1.12.4) ERROR: Shared library dependencies changed! If this is intentional, please update: chrome/installer/linux/debian/expected_deps_ia32 chrome/installer/linux/debian/expected_deps_x64 Original issue's description: > Resurrect Aura Linux accessibility. > > This is based in part on the ATK code we had as part of the Linux GTK port > that went away, but now rewritten on top of AXPlatformNode. This patch > successfully exposes an accessibility tree for Views and exposes top-level > windows and the the role and name of each View. You can test it using > accerciser. This is just to get the infrastructure in place - we need to > implement more of the interface for it to be useful for accessibility tools. > > BUG=463671 > > Committed: https://crrev.com/f65bad877350b5f7857d29e4b1b0d4d3f5c7cb6d > Cr-Commit-Position: refs/heads/master@{#320383} TBR=plundblad@chromium.org,dpranke@chromium.org,sky@chromium.org,gunsch@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463671 Committed: https://crrev.com/999e4c26444e68898d4fa642783263b6e408b7e3 Cr-Commit-Position: refs/heads/master@{#320402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -877 lines) Patch
M build/config/linux/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
M build/config/linux/pkg-config.py View 2 chunks +0 lines, -13 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D tools/accessibility/dump_accessibility_tree_auralinux.py View 1 chunk +0 lines, -32 lines 0 comments Download
M ui/accessibility/BUILD.gn View 2 chunks +0 lines, -17 lines 0 comments Download
M ui/accessibility/accessibility.gyp View 2 chunks +0 lines, -25 lines 0 comments Download
D ui/accessibility/platform/atk_util_auralinux.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/accessibility/platform/atk_util_auralinux.cc View 1 chunk +0 lines, -161 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/accessibility/platform/ax_platform_node_auralinux.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ui/accessibility/platform/ax_platform_node_auralinux.cc View 1 chunk +0 lines, -277 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/gfx/native_widget_types.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility.cc View 2 chunks +2 lines, -3 lines 0 comments Download
D ui/views/accessibility/native_view_accessibility_auralinux.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/views/accessibility/native_view_accessibility_auralinux.cc View 1 chunk +0 lines, -164 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/views_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/views_delegate.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alexmos
Created Revert of Resurrect Aura Linux accessibility.
5 years, 9 months ago (2015-03-12 23:16:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002993002/1
5 years, 9 months ago (2015-03-12 23:17:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 23:18:18 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 23:19:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/999e4c26444e68898d4fa642783263b6e408b7e3
Cr-Commit-Position: refs/heads/master@{#320402}

Powered by Google App Engine
This is Rietveld 408576698