Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: content/test/test_frame_navigation_observer.h

Issue 1002953004: Ensure we properly set PageTransition for iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix style Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_frame_navigation_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_frame_navigation_observer.h
diff --git a/content/test/test_frame_navigation_observer.h b/content/test/test_frame_navigation_observer.h
index 9ff42c53e858e059a1e87f19623b90f30fff74e4..5330c48eb27afedbe9d92678cdd6979575b1036f 100644
--- a/content/test/test_frame_navigation_observer.h
+++ b/content/test/test_frame_navigation_observer.h
@@ -10,6 +10,7 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
+#include "content/public/browser/navigation_details.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/test_utils.h"
@@ -19,7 +20,6 @@ namespace content {
class FrameTreeNode;
class RenderFrameHostImpl;
class WebContents;
-struct LoadCommittedDetails;
// For content_browsertests, which run on the UI thread, run a second
// MessageLoop and quit when the navigation in a specific frame completes
@@ -38,6 +38,11 @@ class TestFrameNavigationObserver : public WebContentsObserver {
// navigations are complete.
void Wait();
+ // Returns the LoadCommittedDetails for the last navigation to commit.
+ const LoadCommittedDetails& load_committed_details() const {
+ return load_committed_details_;
+ }
+
private:
// WebContentsObserver
void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
@@ -60,6 +65,8 @@ class TestFrameNavigationObserver : public WebContentsObserver {
// The number of navigations to wait for.
int number_of_navigations_;
+ LoadCommittedDetails load_committed_details_;
+
// The MessageLoopRunner used to spin the message loop.
scoped_refptr<MessageLoopRunner> message_loop_runner_;
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_frame_navigation_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698