Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1002953003: Implement an OverscrollCurve for Scrollable (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
hansmuller, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Implement an OverscrollCurve for Scrollable When using OverscrollCurve, we continue to scroll beyond the top of the scrollable area but the scroll delta is reduced by 2x. A future CL will add an animation at gesturescrollend to relax back to scroll position 0.0. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d69115c85e1ddf286ba160a8109717e0fb7450d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M sky/examples/stocks-fn/stocklist.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/animation/scroll_curve.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M sky/framework/components/fixed_height_scrollable.dart View 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-12 19:56:58 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-12 20:00:26 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-12 20:08:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d69115c85e1ddf286ba160a8109717e0fb7450d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698