Disable libjpeg turbo getenv()

Disable libjpeg turbo getenv()

getenv() is used in libjpeg_turbo to get environment variable JPEGMEM
which overrides the default max_memory setting from jpeg_mem_init.
However, getenv() is not thread-safe. Now libjpeg may be called from
multiple threads when impl-side-painting is enabled.

BUG=322228
R=noel@chromium.org

Committed: 8692fb5

Committed: 238232

[Alpha Left Google, 2013-12-02 22:33:06]

On 2013/12/02 22:00:18, Xianzhu wrote:

LGTM.

[Noel Gordon, 2013-12-02 23:01:43]

LGTM

[Xianzhu, 2013-12-02 23:06:33]

Committed patchset #1 manually as r8692fb5 (presubmit successful).

[Noel Gordon, 2013-12-02 23:27:48]

BTW, does third_party/libjpeg need a similar change?

[Xianzhu, 2013-12-02 23:40:56]

Committed patchset #2 manually as r238232 (presubmit successful).

[Xianzhu, 2013-12-02 23:42:46]

On 2013/12/02 23:27:48, Noel Gordon (Google) wrote:
> BTW, does third_party/libjpeg need a similar change?

Will do.

BTW, #4 was done in a Android checkout which was incorrect. #6 is the correct
submit.

[Noel Gordon, 2013-12-02 23:50:31]

Yes, Android does not currently use libjpeg_turbo I believe.

[Xianzhu, 2013-12-03 00:00:11]

On 2013/12/02 23:50:31, Noel Gordon (Google) wrote:
> Yes, Android does not currently use libjpeg_turbo I believe.

Actually Android is using libjpeg_turbo; ChromeOS isn't, according to
common.gypi.
#4 problem was caused by a repository issue. The change was submitted to my
local git repo :)

[Noel Gordon, 2013-12-03 08:56:24]

On 2013/12/03 00:00:11, Xianzhu wrote:
> On 2013/12/02 23:50:31, Noel Gordon (Google) wrote:
> > Yes, Android does not currently use libjpeg_turbo I believe.
> 
> Actually Android is using libjpeg_turbo;

My understanding is that Androids did a lot of work to enable USE_SYSTEM_JPEG
(viz., use the system libjpeg that ships with Android NDK) to help minimize the
size of the Android webview.  Maybe that's changed?

> ChromeOS isn't, according to common.gypi

ChromeOS changed on https://code.google.com/p/chromium/issues/detail?id=144296
to use libjpeg in some  circumstances.

[Xianzhu, 2013-12-03 17:11:21]

On 2013/12/03 08:56:24, Noel Gordon (Google) wrote:
> On 2013/12/03 00:00:11, Xianzhu wrote:
> > On 2013/12/02 23:50:31, Noel Gordon (Google) wrote:
> > > Yes, Android does not currently use libjpeg_turbo I believe.
> > 
> > Actually Android is using libjpeg_turbo;
> 
> My understanding is that Androids did a lot of work to enable USE_SYSTEM_JPEG
> (viz., use the system libjpeg that ships with Android NDK) to help minimize
the
> size of the Android webview.  Maybe that's changed?
> 

For now libjpeg is not in Android NDK yet, so Android Chrome still uses
libjpeg_turbo. Andriod WebView is compiled and shipped as a part of a certain
version of Android system, so it can use system libraries not in NDK without
binary compatibility issues.

> > ChromeOS isn't, according to common.gypi
> 
> ChromeOS changed on https://code.google.com/p/chromium/issues/detail?id=144296
> to use libjpeg in some  circumstances.

[Noel Gordon, 2013-12-04 00:24:03]

LGTM and makes sense, thanks.